qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: "reviewer:Incompatible changes" <libvir-list@redhat.com>,
	qemu-block@nongnu.org
Subject: Re: [PATCH] qemu-nbd: Removed deprecated --partition option
Date: Thu, 23 Jan 2020 06:30:05 -0600	[thread overview]
Message-ID: <7084da4a-fa6a-e4ab-868d-2ad397dd5cb3@redhat.com> (raw)
In-Reply-To: <bcf38c8e-c207-73bd-8707-44b500ef3fa2@redhat.com>

On 1/23/20 6:10 AM, Max Reitz wrote:
> On 22.01.20 22:43, Eric Blake wrote:
>> The option was deprecated in 4.0.0 (commit 0ae2d546); it's now been
>> long enough with no complaints to follow through with that process.
>>
>> Signed-off-by: Eric Blake <eblake@redhat.com>
>> ---

>> -@code{qemu-nbd -t -P 1 -f qcow2 file.qcow2}
>> -
>> -can be rewritten as:
>> -
>> -@code{qemu-nbd -t --image-opts driver=raw,offset=1M,size=100M,file.driver=qcow2,file.backing.driver=file,file.backing.filename=file.qcow2}
>> -

>> +can be rewritten as:
>> +
>> +@code{qemu-nbd -t --image-opts driver=raw,offset=1M,size=100M,file.driver=qcow2,file.backing.driver=file,file.backing.filename=file.qcow2}
> 
> I know you just moved it from above, but isn’t this wrong?  Shouldn’t it
> be s/backing/file/g?

Indeed; file.file.driver=file,file.file.filename=file.qcow2 is required 
for it to work, rather than fail with
qemu-nbd: Failed to blk_new_open 
'driver=raw,offset=1m,size=100m,file.driver=qcow2,file.backing.driver=file,file.backing.filename=file4': 
A block device must be specified for "file"

I'll repost with the bug-fix as a separate commit (and it's a shame that 
we've gone nearly a year with no one noticing the typo in the original).

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org



  reply	other threads:[~2020-01-23 14:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-22 21:43 [PATCH] qemu-nbd: Removed deprecated --partition option Eric Blake
2020-01-22 22:00 ` no-reply
2020-01-23 12:10 ` Max Reitz
2020-01-23 12:30   ` Eric Blake [this message]
2020-01-23 12:44     ` Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7084da4a-fa6a-e4ab-868d-2ad397dd5cb3@redhat.com \
    --to=eblake@redhat.com \
    --cc=libvir-list@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).