From: Thomas Huth <thuth@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>
Subject: Re: [PATCH v1 5/6] travis.yml: Detach build and test steps
Date: Tue, 7 Jan 2020 16:24:08 +0100 [thread overview]
Message-ID: <708b652e-83d3-f9b8-aa83-9d70d7b3e96c@redhat.com> (raw)
In-Reply-To: <20200107135311.5215-6-alex.bennee@linaro.org>
On 07/01/2020 14.53, Alex Bennée wrote:
> From: Wainer dos Santos Moschetta <wainersm@redhat.com>
>
> Currently build and test commands are a single step in a
> Travis's `script` block. In order to see the output
> of the tests one needs to scroll down the log to find where
> the build messages ended and the limit is not clear. If
> they were in different steps then Travis would print the
> result build command, which can be easily grep'ed.
>
> So this change is made to detach those commands
> to ease the visualization of the output.
>
> Note that all steps on the `script` block is executed regardless
> if one previous has failed. To overcome it, let's save the
> return code of the build then check whether succeed or failed on
> the test step.
>
> Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Message-Id: <20191230184327.2800-3-wainersm@redhat.com>
> ---
> .travis.yml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index 93838bf0f8b..848a2714efe 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -94,7 +94,8 @@ before_script:
> - mkdir -p ${BUILD_DIR} && cd ${BUILD_DIR}
> - ${SRC_DIR}/configure ${BASE_CONFIG} ${CONFIG} || { cat config.log && exit 1; }
> script:
> - - make -j3 && travis_retry ${TEST_CMD}
> + - BUILD_RC=0 && make -j3 || BUILD_RC=$?
What about using "|| exit 1" instead of "|| BUILD_RC=$?" ?
> + - if [ "$BUILD_RC" -eq 0 ] ; then travis_retry ${TEST_CMD} ; else $(exit $BUILD_RC); fi
> after_script:
> - if command -v ccache ; then ccache --show-stats ; fi
>
>
Thomas
next prev parent reply other threads:[~2020-01-07 15:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 13:53 [PATCH v1 0/6] current testing/next (python and other fixes) Alex Bennée
2020-01-07 13:53 ` [PATCH v1 1/6] hw/i386/x86-iommu: Add missing stubs Alex Bennée
2020-01-07 14:57 ` Thomas Huth
2020-01-07 13:53 ` [PATCH v1 2/6] tests/vm: update openbsd to release 6.6 Alex Bennée
2020-01-07 13:53 ` [PATCH v1 3/6] freebsd: use python37 Alex Bennée
2020-01-07 13:53 ` [PATCH v1 4/6] travis.yml: avocado: Print logs of non-pass tests only Alex Bennée
2020-01-07 13:53 ` [PATCH v1 5/6] travis.yml: Detach build and test steps Alex Bennée
2020-01-07 15:24 ` Thomas Huth [this message]
2020-01-07 13:53 ` [PATCH v1 6/6] travis: install homebrew python for OS X Alex Bennée
2020-01-07 15:18 ` Marc-André Lureau
2020-01-07 19:10 ` Philippe Mathieu-Daudé
2020-01-08 7:00 ` Alex Bennée
2020-01-08 10:48 ` Philippe Mathieu-Daudé
2020-01-08 10:58 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=708b652e-83d3-f9b8-aa83-9d70d7b3e96c@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=fam@euphon.net \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).