From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 324BDCAC5A5 for ; Thu, 25 Sep 2025 11:00:46 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1jhd-0001wP-3M; Thu, 25 Sep 2025 06:59:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1jhc-0001wB-5q for qemu-devel@nongnu.org; Thu, 25 Sep 2025 06:59:56 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v1jhW-0001pE-Fe for qemu-devel@nongnu.org; Thu, 25 Sep 2025 06:59:54 -0400 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-46e29d65728so5288095e9.3 for ; Thu, 25 Sep 2025 03:59:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1758797984; x=1759402784; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4zU0NEarb5pJ0rADAGdh7HoWzRim7kmV72Wf6hv8N1U=; b=JMXgin4nZMll07yAZiHFOne5RnapIVoNgTi02hzD3JlcbRtRJF3WLa8S2lPgB7zJE/ 0Wyc3d93UZOpTnAP87GD+tlK/N4aciU/UEmli+5rQLlY9sJuqCD65sy7dLFtmWgIYNbo 4hUb9oN0bMLaGlwGTd1LAIy56LboL9ZjuQ25kAF8EVB09u5JnC4DAPzRvSpYfrAEhFxm TzYWHb5vMcS0fv3oUaqrpNgWEzvJ/UQsrI4BWcovKxtmrwJglDhKPlpRKs1YExpe7hIs uxmM4n579AXPhlznATM0hNvoqRAVe1LBhug9DwnVxCUz8A6MlrWYVdAEnNGoXZ7bFpHt DoqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758797984; x=1759402784; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4zU0NEarb5pJ0rADAGdh7HoWzRim7kmV72Wf6hv8N1U=; b=CKmoLzThpE9VIKcwDazDm/cz6BBryEB8LYJeV5uFuV2aurDChPaw0o+jE4JzCoj50+ ltZnV11I8GxSNnDNzsAYGdOfLEY5fiZOVf0trWXfZTTLu584+W4GoEPXmKfmmCEosoXH Kp7sjbeASraj/pCEAqAQ2mrAbX8HN+5yfs7gtLvrqZTKIWi4pY16YbHfb8WnMKmD4sG+ +TrwD/tJVrYZ/H3dWSkF9nhxusMzqkztBE6mboo+UDipi5v9vUm/p4XkEEPHVtvtm/a/ 2/BHTaDdZgve+LK4VL9jzIIci4DrqrAmiklrdj4vTkUOzy8A5Je2ChIhrfR3jf2u+kwb CuDg== X-Forwarded-Encrypted: i=1; AJvYcCVPRQFjMVA7mvuidZP9fRhLbv3V+zmE0QS5OJ3/sjhadRJ2X5qudcbyCam78UOyqUzRd/wRUZMWZq24@nongnu.org X-Gm-Message-State: AOJu0YzleTRNKSvUU/WRe2oOeGe89fAqNBRZpdUTyYny5xi1+S2R62RZ s4oMcG2Vh0g62lN2FZvz6Hf0IHzs7pZBpvYb6JVz4Pt6ajaC450zT1Ih9f/EiR3DAo0= X-Gm-Gg: ASbGncvz5fZj96pU4pR/7DaGCB4SewFRSn0QwX/jjlj4QNBFspQm83x9ws6/OCv6cMU PLdP8IFh4NX+UEEKMDACwosDWUeuWTfdPRTaBieYAeZau1HLPr84rDqYkjvPuop0QFnkIL4RjNd mc26nv/gNTceyb1d266jzfAeNT444EbvzUSGSxipr27CRQdynCtMkCCcP07mO/OHkKIbBcpitY4 T6ov22PoFe6rWkBWLydj5xpBDqlB7PcvB00G3y7fKbbvkiD/dbCiKz1p/swZrji9KPVIKfkd7g0 MIoY/Gy6E0LqxCOkg0vNhdl4TPtKbDhJdu707hP5xVj70gQHb0eRUoqDNzTIDoKa0+u57aWLHP7 wrNwVpdWx1eHDy/fcv30YIGOhcjLws3092N5QcZNng9YVKhsag2ZBGqRx6eqcqpuzkg== X-Google-Smtp-Source: AGHT+IGOQjdrS/HfOfl0fqFAE3zZvdkHzj53foWzbuWeTVL5pIQX3JTCoV/QeOemoR0jlUNNqkDS8A== X-Received: by 2002:a05:600c:6306:b0:459:db7b:988e with SMTP id 5b1f17b1804b1-46e329b9bf6mr29119625e9.13.1758797983873; Thu, 25 Sep 2025 03:59:43 -0700 (PDT) Received: from [192.168.69.221] (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-40fb72fb21esm2587954f8f.7.2025.09.25.03.59.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Sep 2025 03:59:43 -0700 (PDT) Message-ID: <708b94d5-c09a-4700-9a40-7937c3b6dff0@linaro.org> Date: Thu, 25 Sep 2025 12:59:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 21/36] target/arm: Improve asserts in define_one_arm_cp_reg Content-Language: en-US To: Richard Henderson , qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, peter.maydell@linaro.org References: <20250916142238.664316-1-richard.henderson@linaro.org> <20250916142238.664316-22-richard.henderson@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <20250916142238.664316-22-richard.henderson@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 16/9/25 16:22, Richard Henderson wrote: > Reject ARM_CP_64BIT with ARM_CP_STATE_BOTH, because encoding > constrains prevent it from working. Remove some extra parens; > distribute ! across && to simplify. > > Signed-off-by: Richard Henderson > --- > target/arm/helper.c | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé