From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2DAB6C5475B for ; Wed, 6 Mar 2024 20:45:55 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rhy91-0005qb-FO; Wed, 06 Mar 2024 15:45:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhy8z-0005qK-8A for qemu-devel@nongnu.org; Wed, 06 Mar 2024 15:45:41 -0500 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rhy8p-00068q-Lt for qemu-devel@nongnu.org; Wed, 06 Mar 2024 15:45:35 -0500 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-412f1961101so2064975e9.0 for ; Wed, 06 Mar 2024 12:45:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709757930; x=1710362730; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bcqzoJde7fTwjsA331VbKvJ/wGDbyYSabnq2e7nudFM=; b=YFBe8PCVisaK3F2HWmfsDDI+MBEOrCAuZ6ydjc/Ph+1JIoUrh+QZHJlyzhw3vjYCYw P/GEbQJ/UkFbJsIXcctcNP11AD0L5KoTjladzZplQhztqOXXg4OZlE3AaajjTKbTuAuf qESxc0vhdYtL/jpLQ8wRwhFW4NoXsRX88zXTqrDGhm30lHMw6TENOTAXh62KUQ0jpdO/ NbY4oanGeDzI0PjKuGUxZxgi/9PQG+GX1FClxbP4YjabJSmBoMfI0Nw1icjTq0DUQkXz ENaOaYZFxktqQuK2IG8BH7W3F+Yc/+53UfIFYQytitoBnBONxRAUtNYRhPSK5bslSK0X zRKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709757930; x=1710362730; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bcqzoJde7fTwjsA331VbKvJ/wGDbyYSabnq2e7nudFM=; b=PQr89BzpRW4SUFkCqFTTYbuUA1yFJYGp7wnWikXr4HZpVVzv05wCs+Iw/eS/1ia33o wquqXAGJzy1lUCtK0rdpRmlVyYwOwRDFmuNZ5+/gHjRAaMxY12kzyrscMlB+50UjdlzU j4R287G9yfo6oMY//lOUHx95IjD+iG3fvI5xKfHwfB6u023NHCtreQA2TD1fQDHgcOzH Xp/IqzhDobw7otFUFab1XiNqKtutPFfRZpdvbrS0gPYDjuXMtBYpYAyHZKFXN1DqYYVA GT35QI3bjBkrA4eApd/pAHeRKwHJu+oZgtOTk6zgOL+gqu8Yh+VulZFsCX4hzME9X9Cd 1ifQ== X-Forwarded-Encrypted: i=1; AJvYcCWptpwoo3B0+UgIgaU4SRlCLaA+T8mQOZJPpl+yZElBIeAkBA1zUiffw2ShgtE3HSFStvUVFI8sfD7Qp84eZqCATGbSG4g= X-Gm-Message-State: AOJu0Yxh2ARU5X9rzEEvDo20+LAfI/vdg6DvevsFvJd37lhtmT/awLkD kHYFQ1YX2mSXb7NvGkwyCn7jNyvIgKMsG5BeT3ipYsCkO6rCjnN9CH7zKJqnrFw= X-Google-Smtp-Source: AGHT+IEphKZQw3b2Wr70jCI8qthEw2rpAeqUkTYoSg0KQv5pUW0fv9gghyq/p8bTddPoiW01rCQWVQ== X-Received: by 2002:a5d:4242:0:b0:33d:b0c6:433c with SMTP id s2-20020a5d4242000000b0033db0c6433cmr11471552wrr.53.1709757929851; Wed, 06 Mar 2024 12:45:29 -0800 (PST) Received: from [192.168.69.100] (vau06-h02-176-184-43-100.dsl.sta.abo.bbox.fr. [176.184.43.100]) by smtp.gmail.com with ESMTPSA id jg7-20020a05600ca00700b00412f778c4c7sm364335wmb.16.2024.03.06.12.45.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Mar 2024 12:45:29 -0800 (PST) Message-ID: <708f7eb4-f1fb-4f8e-8cba-7d270c84847c@linaro.org> Date: Wed, 6 Mar 2024 21:45:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 6/9] virtio-iommu: Add an option to define the input range width Content-Language: en-US To: Eric Auger , eric.auger.pro@gmail.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, mst@redhat.com, jean-philippe@linaro.org, imammedo@redhat.com, peter.maydell@linaro.org, clg@redhat.com, yanghliu@redhat.com, zhenzhong.duan@intel.com Cc: alex.williamson@redhat.com, jasowang@redhat.com, pbonzini@redhat.com, berrange@redhat.com References: <20240306203348.65776-1-eric.auger@redhat.com> <20240306203348.65776-7-eric.auger@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <20240306203348.65776-7-eric.auger@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 6/3/24 21:32, Eric Auger wrote: > aw-bits is a new option that allows to set the bit width of > the input address range. This value will be used as a default for > the device config input_range.end. By default it is set to 64 bits > which is the current value. > > Signed-off-by: Eric Auger > Reviewed-by: Zhenzhong Duan > Reviewed-by: Cédric Le Goater > > --- > > v1 -> v2: > - Check the aw-bits value is within [32,64] > --- > include/hw/virtio/virtio-iommu.h | 1 + > hw/virtio/virtio-iommu.c | 7 ++++++- > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/include/hw/virtio/virtio-iommu.h b/include/hw/virtio/virtio-iommu.h > index 67ea5022af..83a52cc446 100644 > --- a/include/hw/virtio/virtio-iommu.h > +++ b/include/hw/virtio/virtio-iommu.h > @@ -68,6 +68,7 @@ struct VirtIOIOMMU { > Notifier machine_done; > bool granule_frozen; > GranuleMode granule_mode; > + uint8_t aw_bits; > }; > > #endif > diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c > index aab97e1527..9b2813188b 100644 > --- a/hw/virtio/virtio-iommu.c > +++ b/hw/virtio/virtio-iommu.c > @@ -1314,7 +1314,11 @@ static void virtio_iommu_device_realize(DeviceState *dev, Error **errp) > * in vfio realize > */ > s->config.bypass = s->boot_bypass; > - s->config.input_range.end = UINT64_MAX; > + if (s->aw_bits < 32 || s->aw_bits > 64) { > + error_setg(errp, "aw-bits must be within [32,64]"); Don't we need to return? > + } > + s->config.input_range.end = > + s->aw_bits == 64 ? UINT64_MAX : BIT_ULL(s->aw_bits) - 1; > > switch (s->granule_mode) { > case GRANULE_MODE_4K: > @@ -1544,6 +1548,7 @@ static Property virtio_iommu_properties[] = { > DEFINE_PROP_BOOL("boot-bypass", VirtIOIOMMU, boot_bypass, true), > DEFINE_PROP_GRANULE_MODE("granule", VirtIOIOMMU, granule_mode, > GRANULE_MODE_HOST), > + DEFINE_PROP_UINT8("aw-bits", VirtIOIOMMU, aw_bits, 64), > DEFINE_PROP_END_OF_LIST(), > }; >