From: Richard Henderson <richard.henderson@linaro.org>
To: liweiwei <liweiwei@iscas.ac.cn>,
palmer@dabbelt.com, alistair.francis@wdc.com,
bin.meng@windriver.com, qemu-riscv@nongnu.org,
qemu-devel@nongnu.org
Cc: wangjunqiang@iscas.ac.cn, lazyparser@gmail.com,
luruibo2000@163.com, lustrew@foxmail.com
Subject: Re: [RFC 3/6] target/riscv: rvk: add flag support for Zk/Zkn/Zknd/Zknd/Zkne/Zknh/Zks/Zksed/Zksh/Zkr
Date: Tue, 2 Nov 2021 21:21:51 -0400 [thread overview]
Message-ID: <70a3f6e6-26cd-103b-df44-ed86c2e8f10a@linaro.org> (raw)
In-Reply-To: <83e80e8f-485a-84b9-10e6-bac7d54850e1@iscas.ac.cn>
On 11/2/21 9:06 PM, liweiwei wrote:
>
> 在 2021/11/3 上午1:56, Richard Henderson 写道:
>> On 11/1/21 11:11 PM, liweiwei wrote:
>>> + if (cpu->cfg.ext_zk) {
>>> + cpu->cfg.ext_zbkb = true;
>>> + cpu->cfg.ext_zbkc = true;
>>> + cpu->cfg.ext_zbkx = true;
>>> + cpu->cfg.ext_zknd = true;
>>> + cpu->cfg.ext_zkne = true;
>>> + cpu->cfg.ext_zknh = true;
>>> + cpu->cfg.ext_zkr = true;
>>> + }
>>
>> Section 2.12 lists instead the larger Zkn, Zks, Zkt extensions.
>> I think it's better to follow that.
>>
> OK. I'll replace this with setting ext_zkn, ext_zks, ext_zkt true. By the way, Zkt only
> includes partial RVI/M/C instructions. Is it neccessary to distinguish them?
I don't know if Zkt needs to be called out; it probably depends on whether it is exposed
to the guest via some MISA csr extension.
r~
next prev parent reply other threads:[~2021-11-03 1:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 3:11 [RFC 0/6] support subsets of scalar crypto extension liweiwei
2021-11-02 3:11 ` [RFC 1/6] target/riscv: rvk: add flag support for Zbk[bcx] liweiwei
2021-11-02 14:18 ` Richard Henderson
2021-11-02 15:00 ` liweiwei
2021-11-02 3:11 ` [RFC 2/6] target/riscv: rvk: add implementation of instructions for Zbk* - reuse partial instructions of Zbb/Zbc extensions - add brev8 packh, unzip, zip, etc liweiwei
2021-11-02 15:44 ` Richard Henderson
2021-11-03 0:56 ` liweiwei
2021-11-02 3:11 ` [RFC 3/6] target/riscv: rvk: add flag support for Zk/Zkn/Zknd/Zknd/Zkne/Zknh/Zks/Zksed/Zksh/Zkr liweiwei
2021-11-02 17:56 ` Richard Henderson
2021-11-03 1:06 ` liweiwei
2021-11-03 1:21 ` Richard Henderson [this message]
2021-11-03 7:22 ` liweiwei
2021-11-02 3:11 ` [RFC 4/6] target/riscv: rvk: add implementation of instructions for Zk* liweiwei
2021-11-02 18:56 ` Richard Henderson
2021-11-03 1:08 ` liweiwei
2021-11-02 3:11 ` [RFC 5/6] target/riscv: rvk: add CSR support for Zkr: - add SEED CSR - add USEED, SSEED fields for MSECCFG CSR liweiwei
2021-11-02 3:11 ` [RFC 6/6] disas/riscv.c: rvk: add disas support for Zbk* and Zk* instructions liweiwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70a3f6e6-26cd-103b-df44-ed86c2e8f10a@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=bin.meng@windriver.com \
--cc=lazyparser@gmail.com \
--cc=liweiwei@iscas.ac.cn \
--cc=luruibo2000@163.com \
--cc=lustrew@foxmail.com \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=wangjunqiang@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).