From: Paolo Bonzini <pbonzini@redhat.com>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, qemu-devel@nongnu.org
Subject: Re: [PATCH] esp: store lun coming from the MESSAGE OUT phase
Date: Mon, 14 Jun 2021 10:16:27 +0200 [thread overview]
Message-ID: <70ab4483-b0f6-6b12-203e-8b2a940ecd88@redhat.com> (raw)
In-Reply-To: <f78018a5-8845-1fd8-f580-57bafc534e6c@ilande.co.uk>
On 13/06/21 12:40, Mark Cave-Ayland wrote:
>
> Unfortunately the VMSTATE_*_V() macros don't work in ESPState because
> ESPState is currently embedded in both sysbusespscsi and pciespscsi
> using VMSTATE_STRUCT() where the version of the vmstate_esp
> VMStateDescription does not match those in the vmstate_sysbus_esp_scsi
> or vmstate_esp_pci_scsi VMStateDescriptions. This is currently handled
> by adding an explicit mig_version_id field containing the
> vmstate_esp.version_id field and testing accordingly.
>
> The fix is to use the same logic as esp_is_version_5() when adding the
> new field to vmstate_esp. I've tested the changes below squashed into
> your patch, along with the just posted fix for esp_is_version_5(), and
> confirmed that I can reload old qemu-system-sparc images from 5.2 and
> 6.0 as well as git master.
Ah, ok. So I'll squash this fix, thanks!
Paolo
prev parent reply other threads:[~2021-06-14 8:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 11:57 [PATCH] esp: store lun coming from the MESSAGE OUT phase Paolo Bonzini
2021-06-13 10:40 ` Mark Cave-Ayland
2021-06-14 8:16 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70ab4483-b0f6-6b12-203e-8b2a940ecd88@redhat.com \
--to=pbonzini@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).