From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Fam Zheng" <fam@euphon.net>, "Ed Maste" <emaste@freebsd.org>,
qemu-block@nongnu.org,
"Gustavo A . R . Silva" <gustavo@embeddedor.com>,
qemu-devel@nongnu.org, "Han Han" <hhan@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Daniele Buono" <dbuono@linux.vnet.ibm.com>
Subject: Re: [PATCH v2 3/3] hw/usb/dev-uas: Report command additional adb length as unsupported
Date: Thu, 21 Jan 2021 14:17:12 +0100 [thread overview]
Message-ID: <70b42032-c20d-b345-2847-c29d19045e45@redhat.com> (raw)
In-Reply-To: <20210121111426.tcy2fhxzltts2lja@sirius.home.kraxel.org>
On 1/21/21 12:14 PM, Gerd Hoffmann wrote:
> On Wed, Jan 20, 2021 at 04:35:22PM +0100, Philippe Mathieu-Daudé wrote:
>> We are not ready to handle additional CDB data.
>>
>> If a guest sends a packet with such additional data,
>> report the command parameter as not supported.
>>
>> Specify a size (of 1 byte) for the add_cdb member we
>> are not using, to fix the following warning:
>>
>> usb/dev-uas.c:157:31: error: field 'status' with variable sized type 'uas_iu' not at the end of a struct or class is a GNU extension [-Werror,-Wgnu-variable-sized-type-not-at-end]
>> uas_iu status;
>> ^
>>
>> Reported-by: Ed Maste <emaste@FreeBSD.org>
>> Reported-by: Daniele Buono <dbuono@linux.vnet.ibm.com>
>> Reported-by: Han Han <hhan@redhat.com>
>> Reviewed-by: Eric Blake <eblake@redhat.com>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> Cc: Gustavo A. R. Silva <gustavo@embeddedor.com>
>>
>> v2: include Eric feedbacks
>
> Queued 2+3, fixup #2 conflicts due to dropping #1.
Thank you!
prev parent reply other threads:[~2021-01-21 13:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 15:35 [PATCH v2 0/3] hw/usb/dev-uas: Fix Clang 11 -Wgnu-variable-sized-type-not-at-end error Philippe Mathieu-Daudé
2021-01-20 15:35 ` [PATCH v2 1/3] scsi/utils: Rename 'illegal request' -> 'invalid request' Philippe Mathieu-Daudé
2021-01-20 15:45 ` Eric Blake
2021-01-20 16:15 ` Gerd Hoffmann
2021-01-20 16:21 ` Eric Blake
2021-01-20 15:35 ` [PATCH v2 2/3] scsi/utils: Add INVALID_PARAM_VALUE sense code definition Philippe Mathieu-Daudé
2021-01-20 15:35 ` [PATCH v2 3/3] hw/usb/dev-uas: Report command additional adb length as unsupported Philippe Mathieu-Daudé
2021-01-21 11:14 ` Gerd Hoffmann
2021-01-21 13:17 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70b42032-c20d-b345-2847-c29d19045e45@redhat.com \
--to=philmd@redhat.com \
--cc=dbuono@linux.vnet.ibm.com \
--cc=emaste@freebsd.org \
--cc=fam@euphon.net \
--cc=gustavo@embeddedor.com \
--cc=hhan@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).