From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: alex.bennee@linaro.org, qemu-devel@nongnu.org
Subject: Re: [PATCH v4 4/5] tcg/sparc: Add tcg_out_jmpl_const for better tail calls
Date: Sat, 5 Feb 2022 07:44:00 +1100 [thread overview]
Message-ID: <70c374d8-39b8-6799-3652-ad2571a7c0b5@linaro.org> (raw)
In-Reply-To: <CAFEAcA9rfc5ycQCki=qpP-HKQ1S20X0ZM-TxJKX42-8nQ-wmMA@mail.gmail.com>
On 2/5/22 05:34, Peter Maydell wrote:
> On Fri, 4 Feb 2022 at 07:54, Richard Henderson
> <richard.henderson@linaro.org> wrote:
>>
>> Due to mapping changes, we now rarely place the code_gen_buffer
>> near the main executable. Which means that direct calls will
>> now rarely be in range.
>>
>> So, always use indirect calls for tail calls, which allows us to
>> avoid clobbering %o7, and therefore we need not save and restore it.
>>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> As an aside: I found it a bit confusing that tcg_out_mov()
> takes a 'type' argument but ignores it, whereas tcg_out_mov_delay()
> doesn't take a 'type' argument at all.
Mm. tcg_out_mov() is common to all tcg backends, and some hosts do use the type argument.
I didn't add one to tcg_out_mov_delay() because sparc didn't need one.
r~
next prev parent reply other threads:[~2022-02-04 20:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 7:00 [PATCH v4 0/5] tcg/sparc: Unaligned access for user-only Richard Henderson
2022-02-04 7:00 ` [PATCH v4 1/5] tcg/sparc: Add scratch argument to tcg_out_movi_int Richard Henderson
2022-02-04 17:35 ` Peter Maydell
2022-02-04 20:42 ` Richard Henderson
2022-02-04 7:00 ` [PATCH v4 2/5] tcg/sparc: Improve code gen for shifted 32-bit constants Richard Henderson
2022-02-04 7:56 ` Philippe Mathieu-Daudé via
2022-02-04 17:39 ` Peter Maydell
2022-02-04 7:00 ` [PATCH v4 3/5] tcg/sparc: Use the constant pool for 64-bit constants Richard Henderson
2022-02-04 18:18 ` Peter Maydell
2022-02-04 20:41 ` Richard Henderson
2022-02-04 22:20 ` Peter Maydell
2022-02-04 7:00 ` [PATCH v4 4/5] tcg/sparc: Add tcg_out_jmpl_const for better tail calls Richard Henderson
2022-02-04 18:34 ` Peter Maydell
2022-02-04 20:44 ` Richard Henderson [this message]
2022-02-04 7:00 ` [PATCH v4 5/5] tcg/sparc: Support unaligned access for user-only Richard Henderson
2022-02-04 19:07 ` Peter Maydell
2022-02-04 20:55 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70c374d8-39b8-6799-3652-ad2571a7c0b5@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).