From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Claudio Fontana <cfontana@suse.de>,
Nina Schoetterl-Glausch <nsg@linux.ibm.com>,
Thomas Huth <thuth@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
qemu-s390x <qemu-s390x@nongnu.org>,
Ilya Leoshkevich <iii@linux.ibm.com>
Subject: Re: [PATCH v2] target/s390x: improve cpu compatibility check error message
Date: Fri, 15 Mar 2024 06:58:56 +0100 [thread overview]
Message-ID: <70cae0ae-148f-4b6a-839c-423a5ad54b31@linaro.org> (raw)
In-Reply-To: <20240314213746.27163-1-cfontana@suse.de>
On 14/3/24 22:37, Claudio Fontana wrote:
> some users were confused by this message showing under TCG:
>
> Selected CPU generation is too new. Maximum supported model
> in the configuration: 'xyz'
(Note for the maintainer queuing this patch, consider adding
few extra spaces to indent the previously displayed output).
> Clarify that the maximum can depend on the accel, and add a
> hint to try a different one.
>
> Also add a hint for features mismatch to suggest trying
> different accel, QEMU and kernel versions.
>
> Signed-off-by: Claudio Fontana <cfontana@suse.de>
> ---
> target/s390x/cpu_models.c | 22 +++++++++++++++-------
> 1 file changed, 15 insertions(+), 7 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-03-15 5:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 21:37 [PATCH v2] target/s390x: improve cpu compatibility check error message Claudio Fontana
2024-03-15 5:58 ` Philippe Mathieu-Daudé [this message]
2024-03-15 16:59 ` Nina Schoetterl-Glausch
2024-03-15 17:18 ` Claudio Fontana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70cae0ae-148f-4b6a-839c-423a5ad54b31@linaro.org \
--to=philmd@linaro.org \
--cc=cfontana@suse.de \
--cc=iii@linux.ibm.com \
--cc=nsg@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).