From: Thomas Huth <thuth@redhat.com>
To: "Cho, Yu-Chen" <acho@suse.com>, qemu-devel@nongnu.org
Cc: fam@euphon.net, Liang Yan <lyan@suse.com>,
philmd@redhat.com, wainersm@redhat.com, brogers@suse.com,
cfontana@suse.de, alex.bennee@linaro.org
Subject: Re: [PATCH v2] gitlab-ci.yml: Add openSUSE Leap 15.2 for gitlab CI/CD
Date: Mon, 30 Nov 2020 09:28:42 +0100 [thread overview]
Message-ID: <70cc2a9e-a496-f959-3fb9-46c69903ceff@redhat.com> (raw)
In-Reply-To: <20201130042659.29333-1-acho@suse.com>
On 30/11/2020 05.26, Cho, Yu-Chen wrote:
> v2:
> Drop some package from dockerfile to make docker image more light.
>
> v1:
> Add build-system-opensuse jobs and opensuse-leap.docker dockerfile.
> Use openSUSE Leap 15.2 container image in the gitlab-CI.
>
> Signed-off-by: Cho, Yu-Chen <acho@suse.com>
> ---
> .gitlab-ci.d/containers.yml | 5 ++
> .gitlab-ci.yml | 30 +++++++++++
> tests/docker/dockerfiles/opensuse-leap.docker | 54 +++++++++++++++++++
> 3 files changed, 89 insertions(+)
> create mode 100644 tests/docker/dockerfiles/opensuse-leap.docker
Hi!
Sorry, I was too busy to reply last week ... you could also simply ping on
the v2 that you've sent last week, but anyway, let's now continue discussion
here. I gave it a try, and runtime is much better now, indeed:
https://gitlab.com/huth/qemu/-/jobs/868942587
So:
Tested-by: Thomas Huth <thuth@redhat.com>
Patch looks also fine to me, you should just not put the version log above
the "---" but below, otherwise the version log will show up in the final
patch when it gets picked up with "git am".
No need to resend just because of this, though, I can fix that when picking
up the patch. I'll queue for my testing tree and send it once the hard
freeze is over.
Thomas
next prev parent reply other threads:[~2020-11-30 8:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 4:26 [PATCH v2] gitlab-ci.yml: Add openSUSE Leap 15.2 for gitlab CI/CD Cho, Yu-Chen
2020-11-30 8:28 ` Thomas Huth [this message]
2020-11-30 9:11 ` Philippe Mathieu-Daudé
2020-11-30 9:14 ` Philippe Mathieu-Daudé
2020-12-03 3:38 ` AL Yu-Chen Cho
-- strict thread matches above, loose matches on Subject: below --
2020-11-16 11:30 [PATCH] gitlab-ci.yml: Add openSUSE Tumbleweed and Leap " Yu-Chen, Cho
2020-11-24 9:45 ` [PATCH v2] gitlab-ci.yml: Add openSUSE Leap 15.2 " Cho, Yu-Chen
2020-12-08 6:55 ` Thomas Huth
2020-12-08 8:25 ` AL Yu-Chen Cho
2020-12-10 9:32 ` AL Yu-Chen Cho via
2020-12-11 13:09 ` Thomas Huth
2020-12-18 10:56 ` Thomas Huth
2020-12-24 8:55 ` Cho Yu-Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70cc2a9e-a496-f959-3fb9-46c69903ceff@redhat.com \
--to=thuth@redhat.com \
--cc=acho@suse.com \
--cc=alex.bennee@linaro.org \
--cc=brogers@suse.com \
--cc=cfontana@suse.de \
--cc=fam@euphon.net \
--cc=lyan@suse.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).