From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48014) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZig6-0000uR-Ec for qemu-devel@nongnu.org; Thu, 11 Jan 2018 14:38:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eZig5-0003KF-JK for qemu-devel@nongnu.org; Thu, 11 Jan 2018 14:38:18 -0500 References: <20180111183714.22834-2-malbarbo@gmail.com> From: Laurent Vivier Message-ID: <70d15c39-d087-0617-9eb2-1e021e3f7afc@vivier.eu> Date: Thu, 11 Jan 2018 20:38:07 +0100 MIME-Version: 1.0 In-Reply-To: <20180111183714.22834-2-malbarbo@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v2] linux-user: Add AT_SECURE auxval List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marco A L Barbosa , qemu-trivial@nongnu.org, qemu-devel@nongnu.org Le 11/01/2018 à 19:37, Marco A L Barbosa a écrit : > --- > linux-user/elfload.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/linux-user/elfload.c b/linux-user/elfload.c > index 20f3d8c2c3..32a47674e6 100644 > --- a/linux-user/elfload.c > +++ b/linux-user/elfload.c > @@ -1354,7 +1354,7 @@ struct exec > ~(abi_ulong)(TARGET_ELF_EXEC_PAGESIZE-1)) > #define TARGET_ELF_PAGEOFFSET(_v) ((_v) & (TARGET_ELF_EXEC_PAGESIZE-1)) > > -#define DLINFO_ITEMS 14 > +#define DLINFO_ITEMS 15 > > static inline void memcpy_fromfs(void * to, const void * from, unsigned long n) > { > @@ -1786,6 +1786,7 @@ static abi_ulong create_elf_tables(abi_ulong p, int argc, int envc, > NEW_AUX_ENT(AT_HWCAP, (abi_ulong) ELF_HWCAP); > NEW_AUX_ENT(AT_CLKTCK, (abi_ulong) sysconf(_SC_CLK_TCK)); > NEW_AUX_ENT(AT_RANDOM, (abi_ulong) u_rand_bytes); > + NEW_AUX_ENT(AT_SECURE, (abi_ulong) qemu_getauxval(AT_SECURE)); > > #ifdef ELF_HWCAP2 > NEW_AUX_ENT(AT_HWCAP2, (abi_ulong) ELF_HWCAP2); > after adding the comment and the S-o-b of v1: Reviewed-by: Laurent Vivier