From: David Hildenbrand <david@redhat.com>
To: Ilya Leoshkevich <iii@linux.ibm.com>,
Richard Henderson <richard.henderson@linaro.org>,
Thomas Huth <thuth@redhat.com>
Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org,
Nina Schoetterl-Glausch <nsg@linux.ibm.com>
Subject: Re: [PATCH v2 1/2] target/s390x: Fix EXECUTE of relative long instructions
Date: Wed, 15 Mar 2023 09:58:34 +0100 [thread overview]
Message-ID: <70e78bb2-2409-c614-4c17-14688d79af2c@redhat.com> (raw)
In-Reply-To: <20230315001117.337128-2-iii@linux.ibm.com>
On 15.03.23 01:11, Ilya Leoshkevich wrote:
> The code uses the wrong base for relative addressing: it should use the
> target instruction address and not the EXECUTE's address.
>
> Fix by storing the target instruction address in the new CPUS390XState
> member and loading it from the code generated by gen_ri2().
>
> Reported-by: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> ---
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2023-03-15 8:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 0:11 [PATCH v2 0/2] Fix EXECUTE of relative long instructions Ilya Leoshkevich
2023-03-15 0:11 ` [PATCH v2 1/2] target/s390x: " Ilya Leoshkevich
2023-03-15 8:58 ` David Hildenbrand [this message]
2023-03-15 14:33 ` Richard Henderson
2023-03-15 0:11 ` [PATCH v2 2/2] tests/tcg/s390x: Add ex-relative-long.c Ilya Leoshkevich
2023-03-15 14:33 ` Richard Henderson
2023-03-16 17:50 ` Nina Schoetterl-Glausch
2023-03-16 20:55 ` Ilya Leoshkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70e78bb2-2409-c614-4c17-14688d79af2c@redhat.com \
--to=david@redhat.com \
--cc=iii@linux.ibm.com \
--cc=nsg@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).