From: David Woodhouse <dwmw2@infradead.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Eduardo Habkost <eduardo@habkost.net>,
Marcelo Tosatti <mtosatti@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
paul@xen.org
Subject: Re: [RFC] Notify IRQ sources of level interrupt ack/EOI
Date: Wed, 11 Jan 2023 16:58:37 +0000 [thread overview]
Message-ID: <70eb35a08a7c48993812b7f088fa9ae3f2c8b925.camel@infradead.org> (raw)
In-Reply-To: <20230111112425-mutt-send-email-mst@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1115 bytes --]
On Wed, 2023-01-11 at 11:25 -0500, Michael S. Tsirkin wrote:
> On Wed, Jan 11, 2023 at 02:41:58PM +0000, David Woodhouse wrote:
> > This allows drivers to register a callback on a qemu_irq, which is
> > invoked when a level-triggered IRQ is acked on the irqchip.
> >
> > This allows us to simulate level-triggered interrupts more efficiently,
> > by resampling the state of the interrupt only when it actually matters.
>
> I think we tried this with vfio and had to give up on this.
> I don't remember the details though. Alex probably does?
Hm, not sure why there would be any insurmountable problems.
I've seen this working at scale in a different VMM with split-irqchip
and PCI INTX + Xen event channel support.
And it's what the kernel does internally, and exposes through its dual-
eventfd APIs in both KVM IRQ routing and VFIO interrupts.
That said, I don't care *that* much. I can live with the way I've done
it for the Xen support, by polling the status on a vCPU0 vmexit.
Looking at the VFIO code made me throw up in my mouth a little bit, but
I just won't do that again... :)
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5965 bytes --]
next prev parent reply other threads:[~2023-01-11 16:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 14:41 [RFC] Notify IRQ sources of level interrupt ack/EOI David Woodhouse
2023-01-11 16:25 ` Michael S. Tsirkin
2023-01-11 16:58 ` David Woodhouse [this message]
2023-01-11 18:29 ` Alex Williamson
2023-01-11 19:08 ` David Woodhouse
2023-01-11 19:43 ` Alex Williamson
2023-01-11 19:50 ` David Woodhouse
2023-01-11 20:00 ` Alex Williamson
2023-01-11 20:10 ` David Woodhouse
2023-01-12 8:05 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70eb35a08a7c48993812b7f088fa9ae3f2c8b925.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=alex.williamson@redhat.com \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).