From: Paolo Bonzini <pbonzini@redhat.com>
To: Emanuele Giuseppe Esposito <eesposit@redhat.com>, qemu-block@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>, "Fam Zheng" <fam@euphon.net>,
"Vladimir Sementsov-Ogievskiy" <vsementsov@virtuozzo.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
qemu-devel@nongnu.org, "John Snow" <jsnow@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Markus Armbruster" <armbru@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Hanna Reitz" <hreitz@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Eric Blake" <eblake@redhat.com>
Subject: Re: [PATCH v3 13/25] include/sysemu/blockdev.h: move drive_add and inline drive_def
Date: Tue, 12 Oct 2021 13:06:07 +0200 [thread overview]
Message-ID: <711c1dd0-c566-f486-87b1-a5ca8e22b44c@redhat.com> (raw)
In-Reply-To: <20211012084906.2060507-14-eesposit@redhat.com>
On 12/10/21 10:48, Emanuele Giuseppe Esposito wrote:
> + if (type != IF_DEFAULT) {
> + qemu_opt_set(opts, "if", if_name[type], &error_abort);
> + }
To avoid exporting if_name, this can be replaced by a string argument
directly. But in any case this is okay for this series:
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
next prev parent reply other threads:[~2021-10-12 11:27 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 8:48 [PATCH v3 00/25] block layer: split block APIs in global state and I/O Emanuele Giuseppe Esposito
2021-10-12 8:48 ` [PATCH v3 01/25] main-loop.h: introduce qemu_in_main_thread() Emanuele Giuseppe Esposito
2021-10-12 8:48 ` [PATCH v3 02/25] include/block/block: split header into I/O and global state API Emanuele Giuseppe Esposito
2021-10-14 20:31 ` Eric Blake
2021-10-15 10:05 ` Emanuele Giuseppe Esposito
2021-10-21 14:11 ` Stefan Hajnoczi
2021-10-12 8:48 ` [PATCH v3 03/25] assertions for block " Emanuele Giuseppe Esposito
2021-10-12 8:48 ` [PATCH v3 04/25] include/sysemu/block-backend: split header into I/O and global state (GS) API Emanuele Giuseppe Esposito
2021-10-21 14:28 ` Stefan Hajnoczi
2021-10-12 8:48 ` [PATCH v3 05/25] block/block-backend.c: assertions for block-backend Emanuele Giuseppe Esposito
2021-10-12 8:48 ` [PATCH v3 06/25] include/block/block_int: split header into I/O and global state API Emanuele Giuseppe Esposito
2021-10-21 14:35 ` Stefan Hajnoczi
2021-10-12 8:48 ` [PATCH v3 07/25] assertions for block_int " Emanuele Giuseppe Esposito
2021-10-12 8:48 ` [PATCH v3 08/25] block: introduce assert_bdrv_graph_writable Emanuele Giuseppe Esposito
2021-10-12 11:07 ` Paolo Bonzini
2021-10-21 15:09 ` Stefan Hajnoczi
2021-10-12 8:48 ` [PATCH v3 09/25] include/block/blockjob_int.h: split header into I/O and GS API Emanuele Giuseppe Esposito
2021-10-12 8:48 ` [PATCH v3 10/25] assertions for blockjob_int.h Emanuele Giuseppe Esposito
2021-10-12 8:48 ` [PATCH v3 11/25] include/block/blockjob.h: global state API Emanuele Giuseppe Esposito
2021-10-21 14:35 ` Stefan Hajnoczi
2021-10-12 8:48 ` [PATCH v3 12/25] assertions for blockob.h " Emanuele Giuseppe Esposito
2021-10-12 8:48 ` [PATCH v3 13/25] include/sysemu/blockdev.h: move drive_add and inline drive_def Emanuele Giuseppe Esposito
2021-10-12 11:06 ` Paolo Bonzini [this message]
2021-10-21 15:08 ` Stefan Hajnoczi
2021-10-12 8:48 ` [PATCH v3 14/25] include/systemu/blockdev.h: global state API Emanuele Giuseppe Esposito
2021-10-12 11:07 ` Paolo Bonzini
2021-10-12 8:48 ` [PATCH v3 15/25] assertions for blockdev.h " Emanuele Giuseppe Esposito
2021-10-12 8:48 ` [PATCH v3 16/25] include/block/snapshot: global state API + assertions Emanuele Giuseppe Esposito
2021-10-12 8:48 ` [PATCH v3 17/25] block/copy-before-write.h: " Emanuele Giuseppe Esposito
2021-10-21 15:10 ` Stefan Hajnoczi
2021-10-12 8:48 ` [PATCH v3 18/25] block/coroutines: I/O API Emanuele Giuseppe Esposito
2021-10-12 8:49 ` [PATCH v3 19/25] block_int-common.h: split function pointers in BlockDriver Emanuele Giuseppe Esposito
2021-10-12 8:49 ` [PATCH v3 20/25] block_int-common.h: assertion in the callers of BlockDriver function pointers Emanuele Giuseppe Esposito
2021-10-12 8:49 ` [PATCH v3 21/25] block_int-common.h: split function pointers in BdrvChildClass Emanuele Giuseppe Esposito
2021-10-12 8:49 ` [PATCH v3 22/25] block_int-common.h: assertions in the callers of BdrvChildClass function pointers Emanuele Giuseppe Esposito
2021-10-12 8:49 ` [PATCH v3 23/25] block-backend-common.h: split function pointers in BlockDevOps Emanuele Giuseppe Esposito
2021-10-12 8:49 ` [PATCH v3 24/25] job.h: split function pointers in JobDriver Emanuele Giuseppe Esposito
2021-10-21 15:11 ` Stefan Hajnoczi
2021-10-12 8:49 ` [PATCH v3 25/25] job.h: assertions in the callers of JobDriver funcion pointers Emanuele Giuseppe Esposito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=711c1dd0-c566-f486-87b1-a5ca8e22b44c@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=eesposit@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=richard.henderson@linaro.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).