qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Marc-André Lureau" <mlureau@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: marcandre lureau <marcandre.lureau@redhat.com>,
	qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH 05/12] monitor: register the qapi generated commands
Date: Thu, 23 Jun 2016 05:02:30 -0400 (EDT)	[thread overview]
Message-ID: <712802958.1342152.1466672550244.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <d1d5a33e-6de3-4591-79bd-e2cc51158024@redhat.com>

Hi

----- Original Message -----
> 
> 
> On 23/06/2016 02:08, marcandre.lureau@redhat.com wrote:
> > 
> > Stop using the so-called 'middle' mode. Instead, use qmp_find_command()
> > from generated qapi commands registry.
> > 
> > Note: this commit requires a 'make clean' prior to make, since the
> > generated files do not depend on Makefile (due to a cyclic rule
> > introduced in 4115852bb0).
> > 
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> What is the cyclic dependency?

We have in Makefile.target:

Makefile: $(GENERATED_HEADERS)

But we should also or rather have:

$(GENERATED_HEADERS) $(GENERATED_SOURCES): Makefile:

That would be cyclic.


I understand the first rule was added to simplify the dependencies and make sure the generated files are done prior to any building. But it sounds like it's not a conventional way to write your rules and prevent proper dependencies.

Do you know another trick we could use for the generated files?

regards

  reply	other threads:[~2016-06-23  9:02 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-23  0:07 [Qemu-devel] [PATCH 00/12] qapi: remove the 'middle' mode marcandre.lureau
2016-06-23  0:07 ` [Qemu-devel] [PATCH 01/12] qapi-schema: use generated marshaller for 'qmp_capabilities' marcandre.lureau
2016-06-23 22:41   ` Eric Blake
2016-06-23  0:07 ` [Qemu-devel] [PATCH 02/12] qapi-schema: add 'device_add' marcandre.lureau
2016-06-24  3:52   ` Eric Blake
2016-06-23  0:08 ` [Qemu-devel] [PATCH 03/12] monitor: register gen:false commands manually marcandre.lureau
2016-06-24  4:02   ` Eric Blake
2016-06-23  0:08 ` [Qemu-devel] [PATCH 04/12] monitor: remove usage of generated marshal functions marcandre.lureau
2016-06-24  4:23   ` Eric Blake
2016-06-24 14:14     ` Marc-André Lureau
2016-06-24 14:59       ` Eric Blake
2016-06-23  0:08 ` [Qemu-devel] [PATCH 05/12] monitor: register the qapi generated commands marcandre.lureau
2016-06-23  4:38   ` Paolo Bonzini
2016-06-23  9:02     ` Marc-André Lureau [this message]
2016-06-24  4:31   ` Eric Blake
2016-06-24 14:17     ` Marc-André Lureau
2016-06-23  0:08 ` [Qemu-devel] [PATCH 06/12] monitor: remove mhandler.cmd_new marcandre.lureau
2016-06-24  4:39   ` Eric Blake
2016-06-24 14:20     ` Marc-André Lureau
2016-06-24 15:04       ` Eric Blake
2016-06-23  0:08 ` [Qemu-devel] [PATCH 07/12] monitor: implement 'qmp_query_commands' without qmp_cmds marcandre.lureau
2016-06-23  0:08 ` [Qemu-devel] [PATCH 08/12] build-sys: remove qmp-commands-old.h marcandre.lureau
2016-06-23  0:08 ` [Qemu-devel] [PATCH 09/12] qapi: remove the "middle" mode marcandre.lureau
2016-06-23  0:08 ` [Qemu-devel] [PATCH 10/12] monitor: use qmp_dispatch() marcandre.lureau
2016-06-23  0:08 ` [Qemu-devel] [PATCH 11/12] qmp: update qmp_query_spice fallback marcandre.lureau
2016-06-23  0:08 ` [Qemu-devel] [PATCH 12/12] Drop qmp-commands.hx marcandre.lureau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=712802958.1342152.1466672550244.JavaMail.zimbra@redhat.com \
    --to=mlureau@redhat.com \
    --cc=armbru@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).