From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58795)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1bG0Wx-0008Kf-Vs
	for qemu-devel@nongnu.org; Thu, 23 Jun 2016 05:02:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1bG0Wu-0000Gu-Lp
	for qemu-devel@nongnu.org; Thu, 23 Jun 2016 05:02:35 -0400
Received: from mx6-phx2.redhat.com ([209.132.183.39]:34097)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1bG0Wu-0000Gn-EF
	for qemu-devel@nongnu.org; Thu, 23 Jun 2016 05:02:32 -0400
Date: Thu, 23 Jun 2016 05:02:30 -0400 (EDT)
From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau <mlureau@redhat.com>
Message-ID: <712802958.1342152.1466672550244.JavaMail.zimbra@redhat.com>
In-Reply-To: <d1d5a33e-6de3-4591-79bd-e2cc51158024@redhat.com>
References: <20160623000809.4522-1-marcandre.lureau@redhat.com>
	<20160623000809.4522-6-marcandre.lureau@redhat.com>
	<d1d5a33e-6de3-4591-79bd-e2cc51158024@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 05/12] monitor: register the qapi generated
 commands
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: marcandre lureau <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org, armbru@redhat.com

Hi

----- Original Message -----
>=20
>=20
> On 23/06/2016 02:08, marcandre.lureau@redhat.com wrote:
> >=20
> > Stop using the so-called 'middle' mode. Instead, use qmp_find_command()
> > from generated qapi commands registry.
> >=20
> > Note: this commit requires a 'make clean' prior to make, since the
> > generated files do not depend on Makefile (due to a cyclic rule
> > introduced in 4115852bb0).
> >=20
> > Signed-off-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
>=20
> What is the cyclic dependency?

We have in Makefile.target:

Makefile: $(GENERATED_HEADERS)

But we should also or rather have:

$(GENERATED_HEADERS) $(GENERATED_SOURCES): Makefile:

That would be cyclic.


I understand the first rule was added to simplify the dependencies and make=
 sure the generated files are done prior to any building. But it sounds lik=
e it's not a conventional way to write your rules and prevent proper depend=
encies.

Do you know another trick we could use for the generated files?

regards