From: Paolo Bonzini <pbonzini@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH v2] memory_region: Fix name comments
Date: Fri, 10 Mar 2017 09:48:31 +0100 [thread overview]
Message-ID: <713a5748-1a15-55ac-b26e-94d30e870da5@redhat.com> (raw)
In-Reply-To: <20170309163805.GJ2480@work-vm>
On 09/03/2017 17:38, Dr. David Alan Gilbert wrote:
> It is used by all of the _ram specific functions, so it seemed worth
> including the comment.
It's internal though. memory.c users never use it in a way that creates
a RAMBlock.
> (I also see it's used in some of the boards but I don't understand
> why - e.g. hw/ppc/ppc405_boards.c calls it on something that looks
> like RAM. Although perhaps that's related to the 'fix this' above it)
It's a weird 0-length memory region, and it doesn't have a RAMBlock.
Probably needed only to satisfy ppc405ep_init.
ram_bases[0] = 0;
ram_sizes[0] = 0x08000000;
memory_region_init(&ram_memories[1], NULL, "ef405ep.ram1", 0);
ram_bases[1] = 0x00000000;
ram_sizes[1] = 0x00000000;
Paolo
prev parent reply other threads:[~2017-03-10 8:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-09 15:27 [Qemu-devel] [PATCH v2] memory_region: Fix name comments Dr. David Alan Gilbert (git)
2017-03-09 16:07 ` Paolo Bonzini
2017-03-09 16:13 ` Dr. David Alan Gilbert
2017-03-09 16:26 ` Paolo Bonzini
2017-03-09 16:38 ` Dr. David Alan Gilbert
2017-03-10 8:48 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=713a5748-1a15-55ac-b26e-94d30e870da5@redhat.com \
--to=pbonzini@redhat.com \
--cc=dgilbert@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).