qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexandre DERUMIER <aderumier@odiso.com>
To: Andrey Korolyov <andrey@xdel.ru>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,
	qemu block <qemu-block@nongnu.org>, Jeff Cody <jcody@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	Markus Armbruster <armbru@redhat.com>,
	stefanha <stefanha@redhat.com>, pbonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] qapi: Add "detect-zeroes" option to	drive-mirror
Date: Wed, 10 Jun 2015 18:04:02 +0200 (CEST)	[thread overview]
Message-ID: <714037364.269214.1433952242906.JavaMail.zimbra@oxygem.tv> (raw)
In-Reply-To: <CABYiri-MPgZDF=ozn_NJR4iGxOupTro0qJcGjN08rKxtLBrbOg@mail.gmail.com>

>>Sorry, forgot to mention - of course I`ve pulled all previous 
>>zeroing-related queue, so I haven`t had only the QMP-related fix 
>>running on top of the master :) 

Hi, I had a discussion about rbd mirroring, detect-zeroes and sparse target,  some months ago with paolo

http://qemu.11.n7.nabble.com/qemu-drive-mirror-to-rbd-storage-no-sparse-rbd-image-td293642.html

Not sure it's related but 

"Lack of bdrv_co_write_zeroes is why detect-zeroes does not work. 

Lack of bdrv_get_block_status is why sparse->sparse does not work 
without detect-zeroes. 

Paolo 
"
----- Mail original -----
De: "Andrey Korolyov" <andrey@xdel.ru>
À: "Fam Zheng" <famz@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>, "qemu block" <qemu-block@nongnu.org>, "Jeff Cody" <jcody@redhat.com>, "qemu-devel" <qemu-devel@nongnu.org>, "Markus Armbruster" <armbru@redhat.com>, "stefanha" <stefanha@redhat.com>, "pbonzini" <pbonzini@redhat.com>
Envoyé: Mercredi 10 Juin 2015 17:48:54
Objet: Re: [Qemu-devel] [PATCH 1/2] qapi: Add "detect-zeroes" option to	drive-mirror

> '{"execute":"drive-mirror", "arguments": { "device": 
> "drive-virtio-disk0", "target": 
> "rbd:dev-rack2/vm33090-dest:id=qemukvm:key=xxx:auth_supported=cephx\\;none:mon_host=10.6.0.1\\:6789\\;10.6.0.3\\:6789\\;10.6.0.4\\:6789", 
> "mode": "existing", "sync": "full", "detect-zeroes": true, "format": 
> "raw" } }' 

Sorry, forgot to mention - of course I`ve pulled all previous 
zeroing-related queue, so I haven`t had only the QMP-related fix 
running on top of the master :) 

  reply	other threads:[~2015-06-10 16:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-08  7:06 [Qemu-devel] [PATCH 0/2] mirror: Allow detection of zeroes on source sectors Fam Zheng
2015-06-08  7:06 ` [Qemu-devel] [PATCH 1/2] qapi: Add "detect-zeroes" option to drive-mirror Fam Zheng
2015-06-10 15:41   ` Andrey Korolyov
2015-06-10 15:48     ` Andrey Korolyov
2015-06-10 16:04       ` Alexandre DERUMIER [this message]
2015-06-10 16:09         ` Andrey Korolyov
2015-06-08  7:06 ` [Qemu-devel] [PATCH 2/2] iotests: Add test cases for drive-mirror "detect-zeroes" option Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=714037364.269214.1433952242906.JavaMail.zimbra@oxygem.tv \
    --to=aderumier@odiso.com \
    --cc=andrey@xdel.ru \
    --cc=armbru@redhat.com \
    --cc=famz@redhat.com \
    --cc=jcody@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).