Re: [PATCH] ppc/pnv: change the PowerNV machine devices to be non user creatable

[Thomas Huth <thuth@redhat.com>]

On 29/01/2020 12.37, Cédric Le Goater wrote:
> The PowerNV machine emulates an OpenPOWER system and the PowerNV chip
> devices are models of the internal logic of the POWER processor. They
> can not be instantiated by the user on the QEMU command line.

Maybe mention that QEMU currently abort()s if the user tries to do it
anyway.

> The PHB3/PHB4 devices could be an exception in the future after some
> rework on how the device tree is built. For the moment, exclude them
> also.
> 
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
>  hw/pci-host/pnv_phb3.c      | 2 ++
>  hw/pci-host/pnv_phb3_pbcq.c | 1 +
>  hw/pci-host/pnv_phb4.c      | 3 ++-
>  hw/pci-host/pnv_phb4_pec.c  | 2 ++
>  hw/ppc/pnv_core.c           | 2 ++
>  hw/ppc/pnv_homer.c          | 1 +
>  hw/ppc/pnv_lpc.c            | 1 +
>  hw/ppc/pnv_occ.c            | 1 +
>  8 files changed, 12 insertions(+), 1 deletion(-)

Thanks, this fixes the abort()s that have been reported by
scripts/device-crash-test.

Tested-by: Thomas Huth <thuth@redhat.com>