From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF901C04AB6 for ; Fri, 31 May 2019 11:59:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C4F2D2687C for ; Fri, 31 May 2019 11:59:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4F2D2687C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:41682 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWgBu-0006iA-W2 for qemu-devel@archiver.kernel.org; Fri, 31 May 2019 07:59:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44179) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWgB5-0006N5-Aa for qemu-devel@nongnu.org; Fri, 31 May 2019 07:58:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hWgB4-0007jY-CS for qemu-devel@nongnu.org; Fri, 31 May 2019 07:58:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43188) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hWgB2-0007dV-5U; Fri, 31 May 2019 07:58:28 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 372C881E05; Fri, 31 May 2019 11:58:27 +0000 (UTC) Received: from dresden.str.redhat.com (unknown [10.40.205.32]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 564E75DD91; Fri, 31 May 2019 11:58:25 +0000 (UTC) To: Kevin Wolf References: <20190528195338.12376-1-mreitz@redhat.com> <20190530094040.GC4890@linux.fritz.box> From: Max Reitz Openpgp: preference=signencrypt Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: <715382a7-bcb7-e189-638a-2a302da2f85f@redhat.com> Date: Fri, 31 May 2019 13:58:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190530094040.GC4890@linux.fritz.box> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sNkC58YjZ2SIHpkC1XHAVA6VRQK3VeuZt" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 31 May 2019 11:58:27 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [Qemu-devel] [PATCH] qemu-img: Fix options leakage in img_rebase() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --sNkC58YjZ2SIHpkC1XHAVA6VRQK3VeuZt From: Max Reitz To: Kevin Wolf Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org Message-ID: <715382a7-bcb7-e189-638a-2a302da2f85f@redhat.com> Subject: Re: [PATCH] qemu-img: Fix options leakage in img_rebase() References: <20190528195338.12376-1-mreitz@redhat.com> <20190530094040.GC4890@linux.fritz.box> In-Reply-To: <20190530094040.GC4890@linux.fritz.box> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 30.05.19 11:40, Kevin Wolf wrote: > Am 28.05.2019 um 21:53 hat Max Reitz geschrieben: >> img_rebase() can leak a QDict in two occasions. Fix it. >> >> Coverity: CID 1401416 >> Fixes: d16699b64671466b42079c45b89127aeea1ca565 >> Fixes: 330c72957196e0ae382abcaa97ebf4eb9bc8574f >> Signed-off-by: Max Reitz >=20 > Is this based on some other patch? The second hunk doesn't apply. Yes, it=E2=80=99s based on 330c72957196e0ae382abcaa97ebf4eb9bc8574f, as t= he commit message says. At the time I sent this patch, that was just in my pull request, now it=E2=80=99s in master. Max --sNkC58YjZ2SIHpkC1XHAVA6VRQK3VeuZt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAlzxFt8ACgkQ9AfbAGHV z0DXqwf7BnKo/RTlC7/s7kZpiIN00GSvMEKIikyhy1NLiBcU/FhjEvxDRc/TKod1 jCFBew3rCN1OsFK+NaHA1bYfOeAdNkheUYvKji2qO14ibzIGui2oSfZnLabRf82M rhgsQNg1/tvRr/lJmu+QqDvixBycFIXJSmEd/9+nEOlvqdf4ww/aNBLxGA5GDKzw HiXxIPyr4N9K/Rle0NSGPZy4d0StS4B2GjxAzPSh2q5bkVT0FosVQJXxa5N1nG6W eBauUkzHXUNNoZPbFqEbgT49qBbGl9zgV+QvZqGtAAdD9vbdmxkwe3GjYF2Ez83U d4o8g4cu8CX8v9P2peYQfKsCf9r8Cg== =zmCh -----END PGP SIGNATURE----- --sNkC58YjZ2SIHpkC1XHAVA6VRQK3VeuZt--