From: Max Reitz <mreitz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: pkrempa@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] commit: Add top-node/base-node options
Date: Mon, 13 Aug 2018 18:40:17 +0200 [thread overview]
Message-ID: <715752ed-6a7b-a370-ef62-d030ec89e236@redhat.com> (raw)
In-Reply-To: <20180810162658.6562-2-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 874 bytes --]
On 2018-08-10 18:26, Kevin Wolf wrote:
> The block-commit QMP command required specifying the top and base nodes
> of the commit jobs using the file name of that node. While this works
> in simple cases (local files with absolute paths), the file names
> generated for more complicated setups can be hard to predict.
>
> This adds two new options top-node and base-node to the command, which
> allow specifying node names instead. They are mutually exclusive with
> the old options.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> qapi/block-core.json | 24 ++++++++++++++++++------
> blockdev.c | 32 ++++++++++++++++++++++++++++++--
> 2 files changed, 48 insertions(+), 8 deletions(-)
Looks good to me, but you made me a bit cautious with your talk of how
many pitfalls you've encountered on your way to do this change...
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-08-13 16:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-10 16:26 [Qemu-devel] [PATCH 0/2] commit: Add top-node/base-node options Kevin Wolf
2018-08-10 16:26 ` [Qemu-devel] [PATCH 1/2] " Kevin Wolf
2018-08-10 17:33 ` Eric Blake
2018-08-13 9:08 ` Kevin Wolf
2018-08-13 9:35 ` Markus Armbruster
2018-08-13 15:08 ` Eric Blake
2018-08-13 16:40 ` Max Reitz [this message]
2018-08-28 14:26 ` Peter Krempa
2018-09-03 15:03 ` Kevin Wolf
2018-09-04 13:13 ` Alberto Garcia
2018-09-04 14:17 ` Peter Krempa
2018-09-04 14:42 ` Alberto Garcia
2018-09-04 15:00 ` Peter Krempa
2018-09-04 15:34 ` Kevin Wolf
2018-09-05 12:38 ` Peter Krempa
2018-09-05 13:48 ` Eric Blake
2018-09-05 14:02 ` Peter Krempa
2018-09-05 15:04 ` Kevin Wolf
2018-09-04 14:21 ` Peter Krempa
2018-08-10 16:26 ` [Qemu-devel] [PATCH 2/2] qemu-iotests: Test commit with top-node/base-node Kevin Wolf
2018-08-10 17:36 ` Eric Blake
2018-09-03 14:35 ` [Qemu-devel] [PATCH 0/2] commit: Add top-node/base-node options Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=715752ed-6a7b-a370-ef62-d030ec89e236@redhat.com \
--to=mreitz@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).