From: Alex Williamson <alex.williamson@hp.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 6/7] virtio-net: Add new RX filter controls
Date: Mon, 8 Jun 2009 13:01:39 -0600 [thread overview]
Message-ID: <7162ab20906081201y4c598899mdfd5d42c42e17038@mail.gmail.com> (raw)
In-Reply-To: <20090606204845.GC26877@redhat.com>
On Sat, Jun 6, 2009 at 2:48 PM, Michael S. Tsirkin<mst@redhat.com> wrote:
> On Fri, Jun 05, 2009 at 02:47:18PM -0600, Alex Williamson wrote:
>> Add a few new RX modes to better control the receive_filter. These
>> are all fairly obvious features that hardware could provide.
>
> Could you add a bit more detail on motivation for these
> features please?
Sure, e1000 offers RX controls which separate unicast and multicast
promiscuous, these are replicated with allmulti, which has a direct
mapping for Linux, and thus already exists, and alluni, to accept all
unicast packets. With these we could actually do away with
promiscuous, but since we have to dig into the header to determine the
type of packet, I chose to leave promiscuous separate. Promiscuous
also filters before vlan filtering, so has a slightly different
meaning (maybe all-multi/uni should too?).
e1000 also allows the driver to selectively enable/disable RX of
packets to the broadcast address. This is replicated with the
all/no-bcast options. Finally, there may be cases where we want to
receive only unicast or only multicast address for special purpose
network devices. This is provided by the nouni and nomulti options.
A proprietary guest know as DMX intends to make use of these extra
modes. Are there any other interesting, useful and lightweight packet
filters we could implement? Thanks,
Alex
next prev parent reply other threads:[~2009-06-08 19:01 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 20:46 [Qemu-devel] [PATCH 0/7] virtio-net: Filter cleanup/improvements Alex Williamson
2009-06-05 20:46 ` [Qemu-devel] [PATCH 1/7] virtio-net: Add version_id 7 placeholder for vnet header support Alex Williamson
2009-06-05 20:46 ` [Qemu-devel] [PATCH 2/7] virtio-net: Use a byte to store RX mode flags Alex Williamson
2009-06-05 20:47 ` [Qemu-devel] [PATCH 3/7] virtio-net: reorganize receive_filter() Alex Williamson
2009-06-05 20:47 ` [Qemu-devel] [PATCH 4/7] virtio-net: Fix MAC filter overflow handling Alex Williamson
2009-06-05 20:47 ` [Qemu-devel] [PATCH 5/7] virtio-net: MAC filter optimization Alex Williamson
2009-06-05 20:47 ` [Qemu-devel] [PATCH 6/7] virtio-net: Add new RX filter controls Alex Williamson
2009-06-06 20:48 ` Michael S. Tsirkin
2009-06-08 19:01 ` Alex Williamson [this message]
2009-06-08 19:18 ` Anthony Liguori
2009-06-08 19:29 ` Daniel P. Berrange
2009-06-08 21:03 ` Anthony Liguori
2009-06-09 9:57 ` Daniel P. Berrange
2009-06-09 15:00 ` Jamie Lokier
2009-06-09 15:42 ` [Qemu-devel] " Jan Kiszka
2009-06-09 23:50 ` Jamie Lokier
2009-06-10 8:46 ` Michael S. Tsirkin
2009-06-10 8:58 ` Jan Kiszka
2009-06-10 9:07 ` Michael S. Tsirkin
2009-06-10 9:13 ` Gleb Natapov
2009-06-10 9:17 ` Michael S. Tsirkin
2009-06-10 9:22 ` Gleb Natapov
2009-06-10 9:35 ` Michael S. Tsirkin
2009-06-08 20:18 ` [Qemu-devel] " Alex Williamson
2009-06-05 20:47 ` [Qemu-devel] [PATCH 7/7] virtio-net: Increase filter and control limits Alex Williamson
2009-06-06 20:44 ` Michael S. Tsirkin
2009-06-08 18:49 ` Alex Williamson
2009-06-09 19:25 ` [Qemu-devel] [PATCH 0/7] virtio-net: Filter cleanup/improvements Mark McLoughlin
2009-06-09 21:08 ` Alex Williamson
2009-06-10 6:51 ` Rusty Russell
2009-06-10 20:43 ` Alex Williamson
2009-06-12 17:07 ` Mark McLoughlin
2009-06-12 19:19 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7162ab20906081201y4c598899mdfd5d42c42e17038@mail.gmail.com \
--to=alex.williamson@hp.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).