From: Alex Williamson <alex.williamson@hp.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: markmc@redhat.com, rusty@rustcorp.com.au, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] virtio-net: Remove RX_EXTRA feature
Date: Sun, 14 Jun 2009 07:31:37 -0600 [thread overview]
Message-ID: <7162ab20906140631m3b6270e4w3dc7291388a94068@mail.gmail.com> (raw)
In-Reply-To: <20090614093954.GB6959@redhat.com>
On Sun, Jun 14, 2009 at 3:39 AM, Michael S. Tsirkin<mst@redhat.com> wrote:
> On Fri, Jun 12, 2009 at 01:17:04PM -0600, Alex Williamson wrote:
>> No need to use a feature bit to identify the RX modes. The guest
>> will get an error back if the backend doesn't support these controls.
>>
>> Signed-off-by: Alex Williamson <alex.williamson@hp.com>
>
> What's the motivation here - are we running out of feature bits already?
> Using feature bits for everything makes the interface more consistent
> and IMO easier to use.
See the thread starting here:
http://lists.gnu.org/archive/html/qemu-devel/2009-06/msg00519.html
Both Rusty and Mark voted against the feature bit.
Alex
next prev parent reply other threads:[~2009-06-14 13:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-12 19:17 [Qemu-devel] [PATCH] virtio-net: Remove RX_EXTRA feature Alex Williamson
2009-06-14 9:39 ` Michael S. Tsirkin
2009-06-14 13:31 ` Alex Williamson [this message]
2009-06-15 5:18 ` Rusty Russell
2009-06-15 14:45 ` Alex Williamson
2009-06-16 3:19 ` Rusty Russell
2009-06-16 14:29 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7162ab20906140631m3b6270e4w3dc7291388a94068@mail.gmail.com \
--to=alex.williamson@hp.com \
--cc=markmc@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).