From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MFpoF-0005TG-1T for qemu-devel@nongnu.org; Sun, 14 Jun 2009 09:31:43 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MFpoA-0005Pz-S1 for qemu-devel@nongnu.org; Sun, 14 Jun 2009 09:31:42 -0400 Received: from [199.232.76.173] (port=52482 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MFpoA-0005Pr-KW for qemu-devel@nongnu.org; Sun, 14 Jun 2009 09:31:38 -0400 Received: from mail-qy0-f191.google.com ([209.85.221.191]:58318) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MFpoA-0003HG-Br for qemu-devel@nongnu.org; Sun, 14 Jun 2009 09:31:38 -0400 Received: by qyk29 with SMTP id 29so4013141qyk.4 for ; Sun, 14 Jun 2009 06:31:37 -0700 (PDT) MIME-Version: 1.0 Sender: alex.l.williamson@gmail.com In-Reply-To: <20090614093954.GB6959@redhat.com> References: <20090612191626.4227.7273.stgit@kvm.aw> <20090614093954.GB6959@redhat.com> Date: Sun, 14 Jun 2009 07:31:37 -0600 Message-ID: <7162ab20906140631m3b6270e4w3dc7291388a94068@mail.gmail.com> Subject: Re: [Qemu-devel] [PATCH] virtio-net: Remove RX_EXTRA feature From: Alex Williamson Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: markmc@redhat.com, rusty@rustcorp.com.au, qemu-devel@nongnu.org On Sun, Jun 14, 2009 at 3:39 AM, Michael S. Tsirkin wrote: > On Fri, Jun 12, 2009 at 01:17:04PM -0600, Alex Williamson wrote: >> No need to use a feature bit to identify the RX modes. =C2=A0The guest >> will get an error back if the backend doesn't support these controls. >> >> Signed-off-by: Alex Williamson > > What's the motivation here - are we running out of feature bits already? > Using feature bits for everything makes the interface more consistent > and IMO easier to use. See the thread starting here: http://lists.gnu.org/archive/html/qemu-devel/2009-06/msg00519.html Both Rusty and Mark voted against the feature bit. Alex