From: Thomas Huth <thuth@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Cc: patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 1/2] gdbstub: Use qemu_set_cloexec()
Date: Tue, 15 May 2018 07:22:48 +0200 [thread overview]
Message-ID: <716c53cb-89f6-088e-a5f1-47a6c5f740a7@redhat.com> (raw)
In-Reply-To: <20180514173044.5025-2-peter.maydell@linaro.org>
On 14.05.2018 19:30, Peter Maydell wrote:
> Use the utility routine qemu_set_cloexec() rather than
> manually calling fcntl(). This lets us drop the #ifndef _WIN32
> guards and also means Coverity doesn't complain that we're
> ignoring the fcntl error return (CID 1005665, CID 1005667).
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> gdbstub.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2018-05-15 5:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 17:30 [Qemu-devel] [PATCH 0/2] gdbstub: fix a couple of coverity nits Peter Maydell
2018-05-14 17:30 ` [Qemu-devel] [PATCH 1/2] gdbstub: Use qemu_set_cloexec() Peter Maydell
2018-05-14 18:57 ` [Qemu-devel] [Qemu-trivial] " Philippe Mathieu-Daudé
2018-05-15 5:22 ` Thomas Huth [this message]
2018-05-14 17:30 ` [Qemu-devel] [PATCH 2/2] gdbstub: Handle errors in gdb_accept() Peter Maydell
2018-05-14 18:58 ` Philippe Mathieu-Daudé
2018-05-15 5:24 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=716c53cb-89f6-088e-a5f1-47a6c5f740a7@redhat.com \
--to=thuth@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).