From: Eric Blake <eblake@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>,
qemu-devel@nongnu.org, mst@redhat.com,
marcandre.lureau@redhat.com
Subject: Re: [Qemu-devel] [PATCH] libvhost-user: Send messages with no data
Date: Fri, 4 May 2018 08:09:58 -0500 [thread overview]
Message-ID: <71760a5e-1904-b179-6d0c-dbef0aa21778@redhat.com> (raw)
In-Reply-To: <20180504095346.14159-1-dgilbert@redhat.com>
On 05/04/2018 04:53 AM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> The response to a VHOST_USER_POSTCOPY_ADVISE contains a fd but doesn't
s/a fd/an fd/ ? Depends on whether you pronounce it "eff-dee" or
"file-descriptor".
> actually contain any data. FIx vu_message_write so that it doesn't
s/FIx/Fix/
> do a 0-byte write() call, since this was ending up with rc=0
> that was confusing the error handling code.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> contrib/libvhost-user/libvhost-user.c | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
prev parent reply other threads:[~2018-05-04 13:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 9:53 [Qemu-devel] [PATCH] libvhost-user: Send messages with no data Dr. David Alan Gilbert (git)
2018-05-04 9:56 ` Marc-André Lureau
2018-05-04 13:09 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71760a5e-1904-b179-6d0c-dbef0aa21778@redhat.com \
--to=eblake@redhat.com \
--cc=dgilbert@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).