From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47933) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c08Ox-0002im-7k for qemu-devel@nongnu.org; Fri, 28 Oct 2016 10:45:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c08Ot-0007gP-Cl for qemu-devel@nongnu.org; Fri, 28 Oct 2016 10:44:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44160) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c08Ot-0007ft-4g for qemu-devel@nongnu.org; Fri, 28 Oct 2016 10:44:55 -0400 References: <1477640667-4775-1-git-send-email-ashish.mittal@veritas.com> From: Eric Blake Message-ID: <7179b840-077d-a06f-e2ab-4da711029cfd@redhat.com> Date: Fri, 28 Oct 2016 09:44:50 -0500 MIME-Version: 1.0 In-Reply-To: <1477640667-4775-1-git-send-email-ashish.mittal@veritas.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="csWRF7S4ndiqmS4UniK3eg6maw55HQod2" Subject: Re: [Qemu-devel] [PATCH v3] block/vxhs: Add Veritas HyperScale VxHS block device support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ashish Mittal , qemu-devel@nongnu.org, pbonzini@redhat.com, kwolf@redhat.com, armbru@redhat.com, berrange@redhat.com, jcody@redhat.com, famz@redhat.com, ashish.mittal@veritas.com, stefanha@gmail.com, Rakesh.Ranjan@veritas.com, Buddhi.Madhav@veritas.com Cc: Ketan.Nilangekar@veritas.com, Abhijit.Dey@veritas.com, Venkatesha.Mg@veritas.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --csWRF7S4ndiqmS4UniK3eg6maw55HQod2 From: Eric Blake To: Ashish Mittal , qemu-devel@nongnu.org, pbonzini@redhat.com, kwolf@redhat.com, armbru@redhat.com, berrange@redhat.com, jcody@redhat.com, famz@redhat.com, ashish.mittal@veritas.com, stefanha@gmail.com, Rakesh.Ranjan@veritas.com, Buddhi.Madhav@veritas.com Cc: Ketan.Nilangekar@veritas.com, Abhijit.Dey@veritas.com, Venkatesha.Mg@veritas.com Message-ID: <7179b840-077d-a06f-e2ab-4da711029cfd@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3] block/vxhs: Add Veritas HyperScale VxHS block device support References: <1477640667-4775-1-git-send-email-ashish.mittal@veritas.com> In-Reply-To: <1477640667-4775-1-git-send-email-ashish.mittal@veritas.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/28/2016 02:44 AM, Ashish Mittal wrote: > This patch adds support for a new block device type called "vxhs". > Source code for the qnio library that this code loads can be downloaded= from: > https://github.com/MittalAshish/libqnio.git >=20 > Sample command line using the JSON syntax: > ./qemu-system-x86_64 -name instance-00000008 -S -vnc 0.0.0.0:0 -k en-us= > -vga cirrus -device virtio-balloon-pci,id=3Dballoon0,bus=3Dpci.0,addr=3D= 0x5 > -msg timestamp=3Don > 'json:{"driver":"vxhs","vdisk_id":"{c3e9095a-a5ee-4dce-afeb-2a59fb38741= 0}", > "server":{"host":"172.172.17.4","port":"9999"}}' Are the {} really part of vdisk_id? That's not a usual portion of a UUID. And it should probably be spelled vdisk-id. It's a shame that port is a string and not an int, but it matches existing practice, so that part is correct. >=20 > Sample command line using the URI syntax: > qemu-img convert -f raw -O raw -n > /var/lib/nova/instances/_base/0c5eacd5ebea5ed914b6a3e7b18f1ce734c386ad > vxhs://192.168.0.1:9999/%7Bc6718f6b-0401-441d-a8c3-1f0064d75ee0%7D >=20 The URI syntax is potentially harder to use when compared to structured usage (Kevin's work to add -blockdev, which depends on the QAPI definitio= n). > Signed-off-by: Ashish Mittal > --- > v3 changelog: > (1) Added QAPI schema for the VxHS driver. >=20 For this email, I'm focusing just on the QAPI. > +++ b/qapi/block-core.json > @@ -1708,7 +1708,7 @@ > ## > { 'enum': 'BlockdevDriver', > 'data': [ 'archipelago', 'blkdebug', 'blkverify', 'bochs', 'cloop', > - 'dmg', 'file', 'ftp', 'ftps', 'gluster', 'host_cdrom', > + 'dmg', 'file', 'ftp', 'ftps', 'gluster', 'host_cdrom', 'vx= hs', > 'host_device', 'http', 'https', 'luks', 'null-aio', 'null-= co', Missing mention of the new enum value in the comments above. > 'parallels', 'qcow', 'qcow2', 'qed', 'quorum', 'raw', > 'replication', 'tftp', 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat' ] } > @@ -2220,6 +2220,21 @@ > 'data': { 'filename': 'str' } } > =20 > ## > +# @BlockdevOptionsVxHS > +# > +# Driver specific block device options for VxHS > +# > +# @vdisk_id: UUID of VxHS volume Again, this should be vdisk-id. > +# > +# @server: vxhs server IP, port > +# > +# Since: 2.7 You missed 2.7; this should be 2.8 (if you make soft freeze) or even 2.9.= > +## > +{ 'struct': 'BlockdevOptionsVxHS', > + 'data': { 'vdisk_id': 'str', > + 'server': 'InetSocketAddress' } } Is there any way to use a Unix socket, or is this server ONLY accessible over IPv4/IPv6? > + > +## > # @BlockdevOptions > # > # Options for creating a block device. Many options are available for= all > @@ -2283,7 +2298,8 @@ > 'vhdx': 'BlockdevOptionsGenericFormat', > 'vmdk': 'BlockdevOptionsGenericCOWFormat', > 'vpc': 'BlockdevOptionsGenericFormat', > - 'vvfat': 'BlockdevOptionsVVFAT' > + 'vvfat': 'BlockdevOptionsVVFAT', > + 'vxhs': 'BlockdevOptionsVxHS' > } } > =20 > ## >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --csWRF7S4ndiqmS4UniK3eg6maw55HQod2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJYE2RjAAoJEKeha0olJ0NqQmQIAJT4xOGClcm6tH0ETPJHKrZ8 a2upJi8eB4ooeKlzXbypc7XE6zAyJq9gnVAqmL4hgkhnHQLb3/yLDkzTszrwBiOp 0B/zT2672AqCmYj+No1yOHS25/2CK8DFYPX+oLRObd6TE+UWkmSyRdO3OIJ4y8sl kSWWhS3a3VIvOnMjDZ5+Z+uHR2tPIDRoErLkgiGDYvjaI1Xg/kfBFWGKRiQYfl1V ffOu48/x7D+7EO9Tqb/vPZHenDOYJWEnVb8oXzBLrLYlBmMuSSnlywj5O4r7lQUB IZwkR22507+VVeE9ni/r6cLirF2rs/le9spSfAOk9BXRf1mxYxnGq2byTVXOXYI= =KWXa -----END PGP SIGNATURE----- --csWRF7S4ndiqmS4UniK3eg6maw55HQod2--