Re: [Qemu-devel] [PATCH] mptsas: Fix a migration compatible issue

[Paolo Bonzini <pbonzini@redhat.com>]

On 26/07/2016 11:03, Cao jin wrote:
> My previous commit 2e2aa316 removed internal flag msi_in_use, which
> exists in vmstate, use VMSTATE_UNUSED for migration compatibility.
> 
> Reported-by: Amit Shah <amit.shah@redhat.com>
> Suggested-by: Amit Shah <amit.shah@redhat.com>
> Cc: Markus Armbruster <armbru@redhat.com>
> Cc: Marcel Apfelbaum <marcel@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Cc: Amit Shah <amit.shah@redhat.com>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
>  hw/scsi/mptsas.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/scsi/mptsas.c b/hw/scsi/mptsas.c
> index c1a0649..0ed24d1 100644
> --- a/hw/scsi/mptsas.c
> +++ b/hw/scsi/mptsas.c
> @@ -1370,7 +1370,7 @@ static const VMStateDescription vmstate_mptsas = {
>      .post_load = mptsas_post_load,
>      .fields      = (VMStateField[]) {
>          VMSTATE_PCI_DEVICE(dev, MPTSASState),
> -
> +        VMSTATE_UNUSED(sizeof(bool)), /* Was msi_in_use */

This needs to be "1", not sizeof(bool), because vmstate_info_bool writes
a single byte.  I'll fix this and queue the patch (removing Amit's
reviewed-by since it's effectively a different change).

Paolo

>          VMSTATE_UINT32(state, MPTSASState),
>          VMSTATE_UINT8(who_init, MPTSASState),
>          VMSTATE_UINT8(doorbell_state, MPTSASState),
>