From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05392C433FE for ; Thu, 3 Dec 2020 17:32:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 780F7207B0 for ; Thu, 3 Dec 2020 17:32:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 780F7207B0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45928 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kksTH-0004dW-Ct for qemu-devel@archiver.kernel.org; Thu, 03 Dec 2020 12:32:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55330) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kksJx-0006I2-IZ for qemu-devel@nongnu.org; Thu, 03 Dec 2020 12:23:10 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:22903) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kksJs-0003JZ-Ju for qemu-devel@nongnu.org; Thu, 03 Dec 2020 12:23:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607016180; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qNcgZ8i3MCVSUYaduRXoG/N3WAbSgDNZH1qCt9JQPqA=; b=OZvIVuGL9HVh3XDQCfXIJ+HNXYmt6o6igy2tHtxVFEcLQC9tLub499hwFlnttUQzkJI25l T1GJf1X0YMr6he98d47sY99i0+3ppiiQ+eunPMC1N54lADJe9tjgkETzKY1c7DefTCWJbz qQ0CccnCKQyuS2QzAgdaeaCnKdr9ng8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-421-2FkAOLQgNDOoIq0HZaQgdg-1; Thu, 03 Dec 2020 12:22:56 -0500 X-MC-Unique: 2FkAOLQgNDOoIq0HZaQgdg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4CC7B107ACFA; Thu, 3 Dec 2020 17:22:55 +0000 (UTC) Received: from thuth.remote.csb (ovpn-113-167.ams2.redhat.com [10.36.113.167]) by smtp.corp.redhat.com (Postfix) with ESMTP id AC0F06086F; Thu, 3 Dec 2020 17:22:39 +0000 (UTC) Subject: Re: [PATCH] tests/acceptance: test hot(un)plug of ccw devices To: Cornelia Huck , qemu-devel@nongnu.org References: <20201203153917.66685-1-cohuck@redhat.com> From: Thomas Huth Message-ID: <71a7ee0f-8ca1-e3d0-8817-e51d0cb4c02c@redhat.com> Date: Thu, 3 Dec 2020 18:22:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201203153917.66685-1-cohuck@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.495, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wainer dos Santos Moschetta , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, Cleber Rosa , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 03/12/2020 16.39, Cornelia Huck wrote: > Hotplug a virtio-net-ccw device, and then hotunplug it again. Good idea! ... is it also possible with a pci device? > Signed-off-by: Cornelia Huck > --- > > This is on top of "tests/acceptance: enhance s390x devices test" > > --- > tests/acceptance/machine_s390_ccw_virtio.py | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/tests/acceptance/machine_s390_ccw_virtio.py b/tests/acceptance/machine_s390_ccw_virtio.py > index 53b8484f8f9c..487c25c31d3c 100644 > --- a/tests/acceptance/machine_s390_ccw_virtio.py > +++ b/tests/acceptance/machine_s390_ccw_virtio.py > @@ -97,3 +97,17 @@ class S390CCWVirtioMachine(Test): > exec_command_and_wait_for_pattern(self, > 'cat /sys/bus/pci/devices/000a\:00\:00.0/function_id', > '0x0000000c') > + # add another device > + self.vm.command('device_add', driver='virtio-net-ccw', > + devno='fe.0.4711', id='xxx') Could we use a different id, please? xxx sounds so ... well, use your imagination. > + exec_command_and_wait_for_pattern(self, 'dmesg | tail -n 1', 'CRW') That looks like it could be a little bit racy ... what if the kernel outputs another log message by chance, so that tail -n 1 reports that instead. I think it would be better to clear the dmesg log ("dmesg -c") before plugging, and then look at all the new output of "dmesg" without using "tail" afterwards. > + exec_command_and_wait_for_pattern(self, 'ls /sys/bus/ccw/devices/', > + '0.0.4711') > + # and detach it again > + self.vm.command('device_del', id='xxx') > + self.vm.event_wait(name='DEVICE_DELETED', > + match={'data': {'device': 'xxx'}}) > + exec_command_and_wait_for_pattern(self, 'dmesg | tail -n 1', 'CRW') dito > + exec_command_and_wait_for_pattern(self, > + 'ls /sys/bus/ccw/devices/0.0.4711', > + 'No such file or directory') > Thomas PS: Another idea for a test: Looks like that initrd also has a virtio-balloon driver ... we could maybe start with "-device virito-balloon", then change the size of the balloon and check whether the MemTotal in /proc/meminfo changed...