qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Kashyap Chamarthy <kchamart@redhat.com>, qemu-devel@nongnu.org
Cc: armbru@redhat.com, ehabkost@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qapi/misc.json: Remove superfluous words in CpuModelExpansionType
Date: Wed, 3 Oct 2018 09:26:26 -0500	[thread overview]
Message-ID: <71d08ec7-cf39-1fd8-141d-ea1eb7175cdb@redhat.com> (raw)
In-Reply-To: <20181003104605.8477-1-kchamart@redhat.com>

On 10/3/18 5:46 AM, Kashyap Chamarthy wrote:
> While at it, s/QMU/QEMU in @CpuDefinitionInfo.

Could mention that it was a repetition of 'independent of'.

> 
> Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
> ---
>   qapi/misc.json | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/qapi/misc.json b/qapi/misc.json
> index ada9af5add..f98de3a58c 100644
> --- a/qapi/misc.json
> +++ b/qapi/misc.json
> @@ -2017,7 +2017,7 @@
>   #
>   # @migration-safe: whether a CPU definition can be safely used for
>   #                  migration in combination with a QEMU compatibility machine
> -#                  when migrating between different QMU versions and between
> +#                  when migrating between different QEMU versions and between
>   #                  hosts with different sets of (hardware or software)
>   #                  capabilities. If not provided, information is not available
>   #                  and callers should not assume the CPU definition to be
> @@ -2126,11 +2126,11 @@
>   # @static: Expand to a static CPU model, a combination of a static base
>   #          model name and property delta changes. As the static base model will
>   #          never change, the expanded CPU model will be the same, independent of
> -#          independent of QEMU version, machine type, machine options, and
> -#          accelerator options. Therefore, the resulting model can be used by
> -#          tooling without having to specify a compatibility machine - e.g. when
> -#          displaying the "host" model. static CPU models are migration-safe.
> -#
> +#          QEMU version, machine type, machine options, and accelerator options.
> +#          Therefore, the resulting model can be used by tooling without having
> +#          to specify a compatibility machine - e.g. when displaying the "host"
> +#          model. The @static CPU models are migration-safe.
> +
>   # @full: Expand all properties. The produced model is not guaranteed to be
>   #        migration-safe, but allows tooling to get an insight and work with
>   #        model details.
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

  parent reply	other threads:[~2018-10-03 14:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-03 10:46 [Qemu-devel] [PATCH] qapi/misc.json: Remove superfluous words in CpuModelExpansionType Kashyap Chamarthy
2018-10-03 11:11 ` Marc-André Lureau
2018-10-03 14:26 ` Eric Blake [this message]
2018-10-04  9:24   ` Kashyap Chamarthy
2018-10-03 19:00 ` Eduardo Habkost
2018-10-09 11:47   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71d08ec7-cf39-1fd8-141d-ea1eb7175cdb@redhat.com \
    --to=eblake@redhat.com \
    --cc=armbru@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=kchamart@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).