* [Qemu-devel] [PATCH] qapi/misc.json: Remove superfluous words in CpuModelExpansionType
@ 2018-10-03 10:46 Kashyap Chamarthy
2018-10-03 11:11 ` Marc-André Lureau
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Kashyap Chamarthy @ 2018-10-03 10:46 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, armbru, ehabkost, Kashyap Chamarthy
While at it, s/QMU/QEMU in @CpuDefinitionInfo.
Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
---
qapi/misc.json | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/qapi/misc.json b/qapi/misc.json
index ada9af5add..f98de3a58c 100644
--- a/qapi/misc.json
+++ b/qapi/misc.json
@@ -2017,7 +2017,7 @@
#
# @migration-safe: whether a CPU definition can be safely used for
# migration in combination with a QEMU compatibility machine
-# when migrating between different QMU versions and between
+# when migrating between different QEMU versions and between
# hosts with different sets of (hardware or software)
# capabilities. If not provided, information is not available
# and callers should not assume the CPU definition to be
@@ -2126,11 +2126,11 @@
# @static: Expand to a static CPU model, a combination of a static base
# model name and property delta changes. As the static base model will
# never change, the expanded CPU model will be the same, independent of
-# independent of QEMU version, machine type, machine options, and
-# accelerator options. Therefore, the resulting model can be used by
-# tooling without having to specify a compatibility machine - e.g. when
-# displaying the "host" model. static CPU models are migration-safe.
-#
+# QEMU version, machine type, machine options, and accelerator options.
+# Therefore, the resulting model can be used by tooling without having
+# to specify a compatibility machine - e.g. when displaying the "host"
+# model. The @static CPU models are migration-safe.
+
# @full: Expand all properties. The produced model is not guaranteed to be
# migration-safe, but allows tooling to get an insight and work with
# model details.
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] qapi/misc.json: Remove superfluous words in CpuModelExpansionType
2018-10-03 10:46 [Qemu-devel] [PATCH] qapi/misc.json: Remove superfluous words in CpuModelExpansionType Kashyap Chamarthy
@ 2018-10-03 11:11 ` Marc-André Lureau
2018-10-03 14:26 ` Eric Blake
2018-10-03 19:00 ` Eduardo Habkost
2 siblings, 0 replies; 6+ messages in thread
From: Marc-André Lureau @ 2018-10-03 11:11 UTC (permalink / raw)
To: Kashyap Chamarthy; +Cc: QEMU, Markus Armbruster, Eduardo Habkost
Hi
On Wed, Oct 3, 2018 at 3:02 PM Kashyap Chamarthy <kchamart@redhat.com> wrote:
>
> While at it, s/QMU/QEMU in @CpuDefinitionInfo.
>
> Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> qapi/misc.json | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/qapi/misc.json b/qapi/misc.json
> index ada9af5add..f98de3a58c 100644
> --- a/qapi/misc.json
> +++ b/qapi/misc.json
> @@ -2017,7 +2017,7 @@
> #
> # @migration-safe: whether a CPU definition can be safely used for
> # migration in combination with a QEMU compatibility machine
> -# when migrating between different QMU versions and between
> +# when migrating between different QEMU versions and between
> # hosts with different sets of (hardware or software)
> # capabilities. If not provided, information is not available
> # and callers should not assume the CPU definition to be
> @@ -2126,11 +2126,11 @@
> # @static: Expand to a static CPU model, a combination of a static base
> # model name and property delta changes. As the static base model will
> # never change, the expanded CPU model will be the same, independent of
> -# independent of QEMU version, machine type, machine options, and
> -# accelerator options. Therefore, the resulting model can be used by
> -# tooling without having to specify a compatibility machine - e.g. when
> -# displaying the "host" model. static CPU models are migration-safe.
> -#
> +# QEMU version, machine type, machine options, and accelerator options.
> +# Therefore, the resulting model can be used by tooling without having
> +# to specify a compatibility machine - e.g. when displaying the "host"
> +# model. The @static CPU models are migration-safe.
> +
> # @full: Expand all properties. The produced model is not guaranteed to be
> # migration-safe, but allows tooling to get an insight and work with
> # model details.
> --
> 2.17.1
>
>
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] qapi/misc.json: Remove superfluous words in CpuModelExpansionType
2018-10-03 10:46 [Qemu-devel] [PATCH] qapi/misc.json: Remove superfluous words in CpuModelExpansionType Kashyap Chamarthy
2018-10-03 11:11 ` Marc-André Lureau
@ 2018-10-03 14:26 ` Eric Blake
2018-10-04 9:24 ` Kashyap Chamarthy
2018-10-03 19:00 ` Eduardo Habkost
2 siblings, 1 reply; 6+ messages in thread
From: Eric Blake @ 2018-10-03 14:26 UTC (permalink / raw)
To: Kashyap Chamarthy, qemu-devel; +Cc: armbru, ehabkost
On 10/3/18 5:46 AM, Kashyap Chamarthy wrote:
> While at it, s/QMU/QEMU in @CpuDefinitionInfo.
Could mention that it was a repetition of 'independent of'.
>
> Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
> ---
> qapi/misc.json | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/qapi/misc.json b/qapi/misc.json
> index ada9af5add..f98de3a58c 100644
> --- a/qapi/misc.json
> +++ b/qapi/misc.json
> @@ -2017,7 +2017,7 @@
> #
> # @migration-safe: whether a CPU definition can be safely used for
> # migration in combination with a QEMU compatibility machine
> -# when migrating between different QMU versions and between
> +# when migrating between different QEMU versions and between
> # hosts with different sets of (hardware or software)
> # capabilities. If not provided, information is not available
> # and callers should not assume the CPU definition to be
> @@ -2126,11 +2126,11 @@
> # @static: Expand to a static CPU model, a combination of a static base
> # model name and property delta changes. As the static base model will
> # never change, the expanded CPU model will be the same, independent of
> -# independent of QEMU version, machine type, machine options, and
> -# accelerator options. Therefore, the resulting model can be used by
> -# tooling without having to specify a compatibility machine - e.g. when
> -# displaying the "host" model. static CPU models are migration-safe.
> -#
> +# QEMU version, machine type, machine options, and accelerator options.
> +# Therefore, the resulting model can be used by tooling without having
> +# to specify a compatibility machine - e.g. when displaying the "host"
> +# model. The @static CPU models are migration-safe.
> +
> # @full: Expand all properties. The produced model is not guaranteed to be
> # migration-safe, but allows tooling to get an insight and work with
> # model details.
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] qapi/misc.json: Remove superfluous words in CpuModelExpansionType
2018-10-03 14:26 ` Eric Blake
@ 2018-10-04 9:24 ` Kashyap Chamarthy
0 siblings, 0 replies; 6+ messages in thread
From: Kashyap Chamarthy @ 2018-10-04 9:24 UTC (permalink / raw)
To: Eric Blake; +Cc: qemu-devel, armbru, ehabkost
On Wed, Oct 03, 2018 at 09:26:26AM -0500, Eric Blake wrote:
> On 10/3/18 5:46 AM, Kashyap Chamarthy wrote:
> > While at it, s/QMU/QEMU in @CpuDefinitionInfo.
>
> Could mention that it was a repetition of 'independent of'.
Whoever is merging this, please touch up the commit message by adding:
"Remove repetition of 'independent of'"
Thanks!
[...]
--
/kashyap
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] qapi/misc.json: Remove superfluous words in CpuModelExpansionType
2018-10-03 10:46 [Qemu-devel] [PATCH] qapi/misc.json: Remove superfluous words in CpuModelExpansionType Kashyap Chamarthy
2018-10-03 11:11 ` Marc-André Lureau
2018-10-03 14:26 ` Eric Blake
@ 2018-10-03 19:00 ` Eduardo Habkost
2018-10-09 11:47 ` Markus Armbruster
2 siblings, 1 reply; 6+ messages in thread
From: Eduardo Habkost @ 2018-10-03 19:00 UTC (permalink / raw)
To: Kashyap Chamarthy; +Cc: qemu-devel, eblake, armbru
On Wed, Oct 03, 2018 at 12:46:05PM +0200, Kashyap Chamarthy wrote:
> While at it, s/QMU/QEMU in @CpuDefinitionInfo.
>
> Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Will this go through the QAPI tree?
--
Eduardo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] qapi/misc.json: Remove superfluous words in CpuModelExpansionType
2018-10-03 19:00 ` Eduardo Habkost
@ 2018-10-09 11:47 ` Markus Armbruster
0 siblings, 0 replies; 6+ messages in thread
From: Markus Armbruster @ 2018-10-09 11:47 UTC (permalink / raw)
To: Eduardo Habkost; +Cc: Kashyap Chamarthy, qemu-devel
Eduardo Habkost <ehabkost@redhat.com> writes:
> On Wed, Oct 03, 2018 at 12:46:05PM +0200, Kashyap Chamarthy wrote:
>> While at it, s/QMU/QEMU in @CpuDefinitionInfo.
>>
>> Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
>
> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
>
> Will this go through the QAPI tree?
Queued with the commit message updated as requested by Kashyap. Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-10-09 11:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-03 10:46 [Qemu-devel] [PATCH] qapi/misc.json: Remove superfluous words in CpuModelExpansionType Kashyap Chamarthy
2018-10-03 11:11 ` Marc-André Lureau
2018-10-03 14:26 ` Eric Blake
2018-10-04 9:24 ` Kashyap Chamarthy
2018-10-03 19:00 ` Eduardo Habkost
2018-10-09 11:47 ` Markus Armbruster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).