From: Thomas Huth <thuth@redhat.com>
To: Li Qiang <liq3ea@163.com>,
armbru@redhat.com, lvivier@redhat.com, pbonzini@redhat.com,
eric.auger@redhat.com
Cc: liq3ea@gmail.com, qemu-devel@nongnu.org
Subject: Re: [PATCH v2] tests: qmp-cmd-test: fix memory leak
Date: Thu, 16 Jul 2020 09:56:25 +0200 [thread overview]
Message-ID: <71d35a8d-e767-902d-58b2-bb4ce5407988@redhat.com> (raw)
In-Reply-To: <20200715154117.15456-1-liq3ea@163.com>
On 15/07/2020 17.41, Li Qiang wrote:
> Properly free each test response to avoid memory leak and separate
> qtest_qmp() calls with spare lines, in a consistent manner.
>
> Fixes: 5b88849e7b9("tests/qmp-cmd-test: Add
> qmp/object-add-failure-modes"
>
> Reviewed-by: Eric Auger <eric.auger@redhat.com>
> Signed-off-by: Li Qiang <liq3ea@163.com>
> ---
> Change sincve v1: add detailed commit message
>
> tests/qtest/qmp-cmd-test.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
Thanks, queued to https://gitlab.com/huth/qemu/-/commits/qtest-next/
Thomas
prev parent reply other threads:[~2020-07-16 7:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 15:41 [PATCH v2] tests: qmp-cmd-test: fix memory leak Li Qiang
2020-07-16 5:59 ` Markus Armbruster
2020-07-16 6:43 ` Li Qiang
2020-07-16 9:52 ` Markus Armbruster
2020-07-16 10:33 ` Li Qiang
2020-07-16 10:47 ` Thomas Huth
2020-07-16 7:56 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71d35a8d-e767-902d-58b2-bb4ce5407988@redhat.com \
--to=thuth@redhat.com \
--cc=armbru@redhat.com \
--cc=eric.auger@redhat.com \
--cc=liq3ea@163.com \
--cc=liq3ea@gmail.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).