Re: [PATCH v4] tests/qtest: netdev: test stream and dgram backends

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 4/1/23 15:38, Thomas Huth wrote:
> On 03/01/2023 12.00, Laurent Vivier wrote:
>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>> ---
>>
>> Notes:
>>      v4:
>>        - rework EXPECT_STATE()
>>        - use g_dir_make_tmp()
>>      v3:
>>      - Add "-M none" to avoid error:
>>        "No machine specified, and there is no default"
>>      v2:
>>      - Fix ipv6 free port allocation
>>      - Check for IPv4, IPv6, AF_UNIX
>>      - Use g_mkdtemp() rather than g_file_open_tmp()
>>      - Use socketpair() in test_stream_fd()
>>      v1: compared to v14 of "qapi: net: add unix socket type support 
>> to netdev backend":
>>      - use IP addresses 127.0.0.1 and ::1 rather than localhost
>>
>>   tests/qtest/meson.build     |   2 +
>>   tests/qtest/netdev-socket.c | 434 ++++++++++++++++++++++++++++++++++++
>>   2 files changed, 436 insertions(+)
>>   create mode 100644 tests/qtest/netdev-socket.c
> [...]
>> +static void test_stream_fd(void)
>> +{
>> +    QTestState *qts0, *qts1;
>> +    int sock[2];
>> +    int ret;
>> +
>> +    ret = socketpair(AF_LOCAL, SOCK_STREAM, 0, sock);
> 
> I've put your patch into my queue, but this seems to fail on Windows:
> 
>   https://cirrus-ci.com/task/4869069434781696?logs=main#L6562
> 
> Seems like socketpair() does not exist there?

There is qemu_socketpair() and since yesterday available
on win32:
https://lore.kernel.org/qemu-devel/20230103110814.3726795-7-marcandre.lureau@redhat.com/