From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org,
Christoffer Dall <christoffer.dall@linaro.org>,
Anthony Perard <anthony.perard@citrix.com>,
Stefano Stabellini <sstabellini@kernel.org>,
xen-devel@lists.xensource.com
Subject: Re: [Qemu-devel] [RFC 0/7] Move accel, KVM, Xen, qtest files to accel/ subdir
Date: Wed, 21 Dec 2016 16:41:02 +0100 [thread overview]
Message-ID: <72085b3e-9fe2-965d-fcbb-55f916c2642b@redhat.com> (raw)
In-Reply-To: <20161221141541.GG3808@thinpad.lan.raisama.net>
On 21/12/2016 15:15, Eduardo Habkost wrote:
>>
>> ifeq ($(CONFIG_SOFTMMU),y)
>> obj-$(CONFIG_KVM) += kvm-all.c
>> obj-$(call lnot, $(CONFIG_KVM)) += kvm-stub.c
>> endif
>>
>> similar to what is done already in Makefile.objs?
> I assume you mean:
>
> ifeq ($(CONFIG_SOFTMMU),y)
> obj-$(CONFIG_KVM) += kvm-all.c
> endif
> obj-$(call lnot, $(CONFIG_KVM)) += kvm-stub.c
>
> Nothing really wrong, we can do that to avoid using libqemustub.
> I was just trying to avoid a more complex rule involving
> ifeq+lnot, and to avoid including accel/ in obj-y on the
> non-softmmu case.
TCG would need accel/ in obj-y in the non-softmmu case, for things such
as cpu-exec.c and translate-all.c.
Paolo
next prev parent reply other threads:[~2016-12-21 15:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-20 17:43 [Qemu-devel] [RFC 0/7] Move accel, KVM, Xen, qtest files to accel/ subdir Eduardo Habkost
2016-12-20 17:43 ` [Qemu-devel] [RFC 1/7] xen: Move xen-*-stub.c to stubs/ Eduardo Habkost
2016-12-20 17:43 ` [Qemu-devel] [RFC 2/7] xen: Move xen files to accel/ Eduardo Habkost
2016-12-20 17:43 ` [Qemu-devel] [RFC 3/7] kvm: Move some kvm-stub.c code to stubs/kvm.c Eduardo Habkost
2016-12-21 8:42 ` David Hildenbrand
2016-12-20 17:43 ` [Qemu-devel] [RFC 4/7] kvm: Include kvm-stub.o only on CONFIG_SOFTMMU Eduardo Habkost
2016-12-21 7:27 ` Thomas Huth
2016-12-21 8:44 ` David Hildenbrand
2016-12-20 17:43 ` [Qemu-devel] [RFC 5/7] kvm: Move kvm*.c files to accel/ Eduardo Habkost
2016-12-20 17:43 ` [Qemu-devel] [RFC 6/7] accel: Move accel.c " Eduardo Habkost
2016-12-21 7:30 ` Thomas Huth
2016-12-20 17:43 ` [Qemu-devel] [RFC 7/7] accel: Move qtest.c " Eduardo Habkost
2016-12-20 19:01 ` [Qemu-devel] [RFC 0/7] Move accel, KVM, Xen, qtest files to accel/ subdir Stefan Weil
2016-12-21 0:31 ` Stefano Stabellini
2016-12-21 7:37 ` Thomas Huth
2016-12-21 11:21 ` Paolo Bonzini
2016-12-21 13:14 ` Eduardo Habkost
2016-12-21 13:47 ` Paolo Bonzini
2016-12-21 14:15 ` Eduardo Habkost
2016-12-21 15:41 ` Paolo Bonzini [this message]
2017-04-24 10:40 ` Thomas Huth
2017-04-24 19:11 ` Stefano Stabellini
2017-04-24 19:35 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72085b3e-9fe2-965d-fcbb-55f916c2642b@redhat.com \
--to=pbonzini@redhat.com \
--cc=anthony.perard@citrix.com \
--cc=christoffer.dall@linaro.org \
--cc=ehabkost@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).