From: Paolo Bonzini <pbonzini@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: libvir-list@redhat.com, Prasad J Pandit <ppandit@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/3] adlib: mark as insecure and deprecated.
Date: Fri, 26 Oct 2018 10:48:09 +0200 [thread overview]
Message-ID: <7210c7e6-4b85-053c-83c5-524a3b74ef6f@redhat.com> (raw)
In-Reply-To: <20181025085256.20522-3-kraxel@redhat.com>
On 25/10/2018 10:52, Gerd Hoffmann wrote:
> We have a lovely, guest-triggerable buffer overflow in opl2 emulation.
>
> Reproducer:
> outw(0xff60, 0x220);
> outw(0x1020, 0x220);
> outw(0xffb0, 0x220);
> Result:
> Will overflow FM_OPL->AR_TABLE[] (see hw/audio/fmopl.[ch])
I am dumb and I don't understand. In set_ar_dr you get
v = 0xff
ar = 15
dr = 15
and OPL->AR_TABLE[60] is accessed. The size of the array is 75, which
seems to be actually 14 more than required. Likewise OPL->DR_TABLE[60]
is accessed.
The next accesses use SLOT->ksr which is 0 so it's fine too.
Paolo
next prev parent reply other threads:[~2018-10-26 8:48 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 8:52 [Qemu-devel] [PATCH 0/3] RfC: add support for deprecated devices Gerd Hoffmann
2018-10-25 8:52 ` [Qemu-devel] [PATCH 1/3] qdev: add deprecation_reason to DeviceClass Gerd Hoffmann
2018-10-25 10:50 ` P J P
2018-10-25 11:12 ` Philippe Mathieu-Daudé
2018-10-29 9:19 ` Gerd Hoffmann
2018-10-25 8:52 ` [Qemu-devel] [PATCH 2/3] adlib: mark as insecure and deprecated Gerd Hoffmann
2018-10-25 10:56 ` P J P
2018-10-25 20:40 ` [Qemu-devel] [libvirt] " Daniel P. Berrangé
2018-10-26 7:08 ` P J P
2018-10-26 9:54 ` Daniel P. Berrangé
2018-10-26 12:35 ` P J P
2018-10-25 11:15 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-10-25 20:27 ` Thomas Huth
2018-10-26 8:48 ` Paolo Bonzini [this message]
2018-10-26 9:34 ` P J P
2018-10-26 10:01 ` Paolo Bonzini
2018-10-26 11:53 ` P J P
2018-10-29 9:05 ` Gerd Hoffmann
2018-10-25 8:52 ` [Qemu-devel] [PATCH 3/3] cirrus: mark as deprecated Gerd Hoffmann
2018-10-25 10:59 ` P J P
2018-10-25 11:17 ` Philippe Mathieu-Daudé
2018-10-25 20:28 ` Thomas Huth
2018-10-25 20:37 ` Daniel P. Berrangé
2018-10-26 7:03 ` P J P
2018-10-26 9:42 ` Daniel P. Berrangé
2018-10-26 9:59 ` Daniel P. Berrangé
2018-10-26 10:03 ` Paolo Bonzini
2018-10-26 14:14 ` Daniel P. Berrangé
2018-10-26 18:56 ` P J P
2018-10-26 10:40 ` Dr. David Alan Gilbert
2018-10-26 13:25 ` [Qemu-devel] [libvirt] " Christian Borntraeger
2018-10-26 8:48 ` Cole Robinson
2018-10-26 9:43 ` Daniel P. Berrangé
2018-10-29 9:12 ` [Qemu-devel] " Gerd Hoffmann
2018-10-30 18:00 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7210c7e6-4b85-053c-83c5-524a3b74ef6f@redhat.com \
--to=pbonzini@redhat.com \
--cc=kraxel@redhat.com \
--cc=libvir-list@redhat.com \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).