From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 842CEC433EF for ; Fri, 3 Sep 2021 18:45:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F097561051 for ; Fri, 3 Sep 2021 18:45:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F097561051 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:33636 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mMEBr-000285-PH for qemu-devel@archiver.kernel.org; Fri, 03 Sep 2021 14:45:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33588) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMEAh-0001Pn-Rb for qemu-devel@nongnu.org; Fri, 03 Sep 2021 14:44:15 -0400 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:33449) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mMEAg-0006Pp-AH for qemu-devel@nongnu.org; Fri, 03 Sep 2021 14:44:15 -0400 Received: by mail-wr1-x432.google.com with SMTP id b10so77525wru.0 for ; Fri, 03 Sep 2021 11:44:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gCNlA+PaIivbti3pmNIpIeSQ2CD5CQoAALCc23OZak0=; b=yDB2gl82GWO2qoHKL1OqHUXy5PTGjaJHBfJN1GlsQYMaNYq2HP5mg8Ul6Dg2Ekwfof lUrFCRnI3bUcROlL7ODnkQHq8C6QmLLoJ1oLq1g5nuhJxqdgm2fEfGLDKRvdFHPNA6fz p9gIjgJt1KcMAwbIJHu8h1lZBwpLr/iby9AHp4Fi55iPHAdtNalHnO8+rjnJrbY0OaJ9 D1tLfsp/wQOz2/sonZ2eneNVIS72lQwD88ysLGx2rMDcEiwlaompr48n5Y+in2PdAY/D SxFA0BZ67VODAamc22U/rJfIBBq6txMDyXb1zd1Krs+k7dNBAJp+x6BXBXph0ozEmCMQ hItA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gCNlA+PaIivbti3pmNIpIeSQ2CD5CQoAALCc23OZak0=; b=UAPCIUbwzkskAW8SMtR9VNKU7C8pxm/pVfWwuqeeLN2LhYkyqSPovcgVyz2BTbReoJ kVFC5Z1Ex4Ct6qHJUwJqYqclJjRjbXaVTDIcgmkFNqzlhlP3Gckpc4wkFpdXx3AWiMnt xQNyDHMYZHsdT8/AvyUo58O4e6h4Gyg+UUg18Ef8sJ3mQodliGEhbXW4+kSd/H6aiLro NbJXahsxZzItC/byrCmOrK3IhFeRmGPi9YKLoRpA3W6OSFx9c4CO5Oo4QwJ36NDuigvO WDHbjSJYmFnFXNe4u03B34Y/gP9M1GTBLys+SxdrVbi+woI8Dnl6VFFAsMvuv105dAZH QTAg== X-Gm-Message-State: AOAM531T9H8YD/mRMzy/9PggI05ZLWF4zDp9ZnC3CigQ9amAF/2HOL1s Re/DIopBh7XdwR2KVTPvHL2qJw== X-Google-Smtp-Source: ABdhPJxpxIzNCrqJvI2DuelaFiX7/AyWb52VaTAUehBvqG3HdF6GibO2sD3UFQjxI5xVKLVGuZSY5w== X-Received: by 2002:adf:b741:: with SMTP id n1mr522353wre.120.1630694652253; Fri, 03 Sep 2021 11:44:12 -0700 (PDT) Received: from [192.168.8.107] (190.red-2-142-216.dynamicip.rima-tde.net. [2.142.216.190]) by smtp.gmail.com with ESMTPSA id y24sm228474wma.9.2021.09.03.11.44.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 11:44:11 -0700 (PDT) Subject: Re: [PATCH v9 02/14] target/riscv: Reassign instructions to the Zba-extension To: Philipp Tomsich , qemu-devel@nongnu.org References: <20210903170100.2529121-1-philipp.tomsich@vrull.eu> <20210903170100.2529121-3-philipp.tomsich@vrull.eu> From: Richard Henderson Message-ID: <72149469-c2f7-b235-b99a-7502dab5783a@linaro.org> Date: Fri, 3 Sep 2021 20:44:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210903170100.2529121-3-philipp.tomsich@vrull.eu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=richard.henderson@linaro.org; helo=mail-wr1-x432.google.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.888, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kito Cheng , Alistair Francis Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/3/21 7:00 PM, Philipp Tomsich wrote: > @@ -624,14 +630,16 @@ GEN_TRANS_SHADD_UW(3) > > static void gen_add_uw(TCGv ret, TCGv arg1, TCGv arg2) > { > - tcg_gen_ext32u_tl(arg1, arg1); > - tcg_gen_add_tl(ret, arg1, arg2); > + TCGv t = tcg_temp_new(); > + tcg_gen_ext32u_tl(t, arg1); > + tcg_gen_add_tl(ret, t, arg2); > + tcg_temp_free(t); > } Good fix, but unrelated to $SUBJECT. Split it out. r~