From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Zhao Liu <zhao1.liu@linux.intel.com>,
Eduardo Habkost <eduardo@habkost.net>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Yanan Wang <wangyanan55@huawei.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Eric Blake <eblake@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, Zhenyu Wang <zhenyu.z.wang@intel.com>,
Dapeng Mi <dapeng1.mi@intel.com>,
Zhuocheng Ding <zhuocheng.ding@intel.com>,
Robert Hoo <robert.hu@linux.intel.com>,
Xiaoyao Li <xiaoyao.li@intel.com>,
Like Xu <like.xu.linux@gmail.com>, Zhao Liu <zhao1.liu@intel.com>
Subject: Re: [PATCH RESEND 09/18] i386: Fix comment style in topology.h
Date: Mon, 13 Feb 2023 14:40:52 +0100 [thread overview]
Message-ID: <7214d952-2a12-7ab2-f8c2-51cffc25aa2c@linaro.org> (raw)
In-Reply-To: <20230213093625.158170-10-zhao1.liu@linux.intel.com>
On 13/2/23 10:36, Zhao Liu wrote:
> From: Zhao Liu <zhao1.liu@intel.com>
>
> For function comments in this file, keep the comment style consistent
> with other places.
>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
> include/hw/i386/topology.h | 33 +++++++++++++++++----------------
> 1 file changed, 17 insertions(+), 16 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-02-13 13:41 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 9:36 [PATCH RESEND 00/18] Support smp.clusters for x86 Zhao Liu
2023-02-13 9:36 ` [PATCH RESEND 01/18] machine: Fix comment of machine_parse_smp_config() Zhao Liu
2023-02-13 13:31 ` wangyanan (Y) via
2023-02-14 14:22 ` Zhao Liu
2023-02-13 9:36 ` [PATCH RESEND 02/18] tests: Rename test-x86-cpuid.c to test-x86-apicid.c Zhao Liu
2023-02-15 2:36 ` wangyanan (Y) via
2023-02-15 3:35 ` Zhao Liu
2023-02-15 7:44 ` wangyanan (Y) via
2023-02-13 9:36 ` [PATCH RESEND 03/18] softmmu: Fix CPUSTATE.nr_cores' calculation Zhao Liu
2023-02-15 2:58 ` wangyanan (Y) via
2023-02-15 3:37 ` Zhao Liu
2023-02-13 9:36 ` [PATCH RESEND 04/18] i386/cpu: Fix number of addressable IDs in CPUID.04H Zhao Liu
2023-02-15 10:11 ` wangyanan (Y) via
2023-02-15 14:33 ` Zhao Liu
2023-02-20 6:59 ` Xiaoyao Li
2023-02-22 6:37 ` Zhao Liu
2023-02-23 3:52 ` Xiaoyao Li
2023-02-13 9:36 ` [PATCH RESEND 05/18] i386/cpu: Consolidate the use of topo_info in cpu_x86_cpuid() Zhao Liu
2023-02-15 3:28 ` wangyanan (Y) via
2023-02-15 7:10 ` Zhao Liu
2023-02-15 7:08 ` wangyanan (Y) via
2023-02-13 9:36 ` [PATCH RESEND 06/18] i386: Introduce module-level cpu topology to CPUX86State Zhao Liu
2023-02-15 7:41 ` wangyanan (Y) via
2023-02-13 9:36 ` [PATCH RESEND 07/18] i386: Support modules_per_die in X86CPUTopoInfo Zhao Liu
2023-02-15 10:38 ` wangyanan (Y) via
2023-02-15 14:35 ` Zhao Liu
2023-02-16 2:34 ` wangyanan (Y) via
2023-02-16 4:33 ` Zhao Liu
2023-02-13 9:36 ` [PATCH RESEND 08/18] i386: Support module_id in X86CPUTopoIDs Zhao Liu
2023-02-13 9:36 ` [PATCH RESEND 09/18] i386: Fix comment style in topology.h Zhao Liu
2023-02-13 13:40 ` Philippe Mathieu-Daudé [this message]
2023-02-14 2:37 ` wangyanan (Y) via
2023-02-15 10:54 ` wangyanan (Y) via
2023-02-15 14:35 ` Zhao Liu
2023-02-13 9:36 ` [PATCH RESEND 10/18] i386: Update APIC ID parsing rule to support module level Zhao Liu
2023-02-15 11:06 ` wangyanan (Y) via
2023-02-15 15:03 ` Zhao Liu
2023-02-16 2:40 ` wangyanan (Y) via
2023-02-13 9:36 ` [PATCH RESEND 11/18] i386/cpu: Introduce cluster-id to X86CPU Zhao Liu
2023-02-13 9:36 ` [PATCH RESEND 12/18] tests: Add test case of APIC ID for module level parsing Zhao Liu
2023-02-15 11:22 ` wangyanan (Y) via
2023-02-13 9:36 ` [PATCH RESEND 13/18] hw/i386/pc: Support smp.clusters for x86 PC machine Zhao Liu
2023-02-14 2:34 ` wangyanan (Y) via
2023-02-13 9:36 ` [PATCH RESEND 14/18] i386: Add cache topology info in CPUCacheInfo Zhao Liu
2023-02-15 12:17 ` wangyanan (Y) via
2023-02-15 15:07 ` Zhao Liu
2023-02-13 9:36 ` [PATCH RESEND 15/18] i386: Use CPUCacheInfo.share_level to encode CPUID[4].EAX[bits 25:14] Zhao Liu
2023-02-13 9:36 ` [PATCH RESEND 16/18] i386: Fix NumSharingCache for CPUID[0x8000001D].EAX[bits 25:14] Zhao Liu
2023-02-15 12:32 ` wangyanan (Y) via
2023-02-15 15:09 ` Zhao Liu
2023-02-13 9:36 ` [PATCH RESEND 17/18] i386: Use CPUCacheInfo.share_level to encode " Zhao Liu
2023-02-13 9:36 ` [PATCH RESEND 18/18] i386: Add new property to control L2 cache topo in CPUID.04H Zhao Liu
2023-02-16 13:14 ` wangyanan (Y) via
2023-02-17 3:35 ` Zhao Liu
2023-02-17 3:45 ` wangyanan (Y) via
2023-02-20 2:54 ` Zhao Liu
2023-02-17 4:07 ` wangyanan (Y) via
2023-02-17 7:26 ` Zhao Liu
2023-02-17 9:08 ` wangyanan (Y) via
2023-02-20 2:49 ` Zhao Liu
2023-02-20 3:52 ` wangyanan (Y) via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7214d952-2a12-7ab2-f8c2-51cffc25aa2c@linaro.org \
--to=philmd@linaro.org \
--cc=armbru@redhat.com \
--cc=dapeng1.mi@intel.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=like.xu.linux@gmail.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=robert.hu@linux.intel.com \
--cc=wangyanan55@huawei.com \
--cc=xiaoyao.li@intel.com \
--cc=zhao1.liu@intel.com \
--cc=zhao1.liu@linux.intel.com \
--cc=zhenyu.z.wang@intel.com \
--cc=zhuocheng.ding@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).