From: Thomas Huth <thuth@redhat.com>
To: John Arbuckle <programmingkidx@gmail.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] configure: Change capstone's default state to disabled
Date: Fri, 19 Apr 2019 09:10:46 +0200 [thread overview]
Message-ID: <723372ae-a37a-d7cd-098f-452c7513ce8a@redhat.com> (raw)
In-Reply-To: <20190418224706.14014-1-programmingkidx@gmail.com>
On 19/04/2019 00.47, John Arbuckle wrote:
> Capstone is not necessary in order to use QEMU. Disable it by default.
> This will save the user the pain of having to figure why QEMU isn't
> building when this library is missing.
>
> Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 1c563a7027..77d7967f92 100755
> --- a/configure
> +++ b/configure
> @@ -433,7 +433,7 @@ opengl_dmabuf="no"
> cpuid_h="no"
> avx2_opt=""
> zlib="yes"
> -capstone=""
> +capstone="no"
> lzo=""
> snappy=""
> bzip2=""
AFAIK we ship capstone as a submodule, so how can this be missing? Also,
our philosophy is to keep everything enabled by default if possible, so
that the code paths don't bitrot. Thus I don't think that disabling this
by default is a good idea. ... so if you've got a problem here, there
must be another solution (e.g. is the system capstone detection not
working right on your system?).
Thomas
next prev parent reply other threads:[~2019-04-19 7:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 22:47 [Qemu-devel] [PATCH] configure: Change capstone's default state to disabled John Arbuckle
2019-04-18 22:47 ` John Arbuckle
2019-04-19 7:10 ` Thomas Huth [this message]
2019-04-19 7:10 ` Thomas Huth
2019-04-19 13:44 ` G 3
2019-04-19 13:44 ` G 3
2019-04-19 18:22 ` Richard Henderson
2019-04-19 18:22 ` Richard Henderson
2019-04-19 23:48 ` Programmingkid
2019-04-19 23:48 ` Programmingkid
2019-04-20 10:40 ` Thomas Huth
2019-04-20 10:40 ` Thomas Huth
2019-05-11 17:21 ` Programmingkid
2019-05-11 18:05 ` Thomas Huth
2019-05-11 18:28 ` Programmingkid
2019-05-12 13:47 ` Thomas Huth
2019-05-13 9:08 ` Daniel P. Berrangé
2019-05-13 9:48 ` Peter Maydell
2019-05-13 9:50 ` Daniel P. Berrangé
2019-05-15 3:30 ` Programmingkid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=723372ae-a37a-d7cd-098f-452c7513ce8a@redhat.com \
--to=thuth@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=programmingkidx@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).