From: Max Reitz <mreitz@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] iotests: Do not run the iotests during "make check" anymore
Date: Wed, 2 Oct 2019 16:39:31 +0200 [thread overview]
Message-ID: <725c14db-2ab7-5ac5-d47d-42d0104b7d93@redhat.com> (raw)
In-Reply-To: <20191002142146.6124-1-thuth@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 979 bytes --]
On 02.10.19 16:21, Thomas Huth wrote:
> Running the iotests during "make check" is causing more headaches than
> benefits for the block layer maintainers, so let's disable the iotests
> during "make check" again.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/Makefile.include | 2 +-
> tests/qemu-iotests/group | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
I’ll leave this patch on the list for a while so that others can speak
up if they disagree.
The problem is that this causes headaches of rather high importance
(make check), and I have to deal with them. I’ll gladly accept help in
dealing with them, but without such help, I don’t feel like it’s worth it.
As far as I’m aware, the plan is to still the iotests in e.g. Travis,
and maybe even more thoroughly then (because we won’t be as constrained
by the test duration), just not in make check.
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-10-02 14:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 14:21 [PATCH] iotests: Do not run the iotests during "make check" anymore Thomas Huth
2019-10-02 14:39 ` Max Reitz [this message]
2019-10-02 15:03 ` Daniel P. Berrangé
2019-10-02 15:10 ` Thomas Huth
2019-10-02 15:50 ` Max Reitz
2019-10-02 23:51 ` John Snow
2019-10-07 13:03 ` Max Reitz
2019-10-07 19:10 ` John Snow
2019-10-02 17:32 ` Alex Bennée
2019-10-02 17:46 ` Thomas Huth
2019-10-07 10:00 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=725c14db-2ab7-5ac5-d47d-42d0104b7d93@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).