From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56255) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsY3f-0001WX-Jc for qemu-devel@nongnu.org; Fri, 07 Oct 2016 12:31:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bsY3a-0002Ir-QJ for qemu-devel@nongnu.org; Fri, 07 Oct 2016 12:31:39 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:60199) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsY3a-0002Ic-HJ for qemu-devel@nongnu.org; Fri, 07 Oct 2016 12:31:34 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u97GUeNc013554 for ; Fri, 7 Oct 2016 12:31:33 -0400 Received: from e31.co.us.ibm.com (e31.co.us.ibm.com [32.97.110.149]) by mx0a-001b2d01.pphosted.com with ESMTP id 25xbu69b29-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 07 Oct 2016 12:31:33 -0400 Received: from localhost by e31.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 7 Oct 2016 10:31:32 -0600 References: <1475519097-27611-1-git-send-email-duanj@linux.vnet.ibm.com> <1475519097-27611-5-git-send-email-duanj@linux.vnet.ibm.com> <20161005165638.GC11921@work-vm> <20161006190156.GE3087@work-vm> <6420ae77-c205-6e24-d06e-2bbb28447b23@redhat.com> <20161007143445.GA25928@work-vm> From: Jianjun Duan Date: Fri, 7 Oct 2016 09:31:16 -0700 MIME-Version: 1.0 In-Reply-To: <20161007143445.GA25928@work-vm> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Message-Id: <72a0ee2a-297c-02cd-1af5-215ad463b474@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v5 4/6] migration: migrate QTAILQ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" , Paolo Bonzini Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, dmitry@daynix.com, peter.maydell@linaro.org, kraxel@redhat.com, mst@redhat.com, david@gibson.dropbear.id.au, veroniabahaa@gmail.com, quintela@redhat.com, amit.shah@redhat.com, mreitz@redhat.com, kwolf@redhat.com, rth@twiddle.net, aurelien@aurel32.net, leon.alrae@imgtec.com, blauwirbel@gmail.com, mark.cave-ayland@ilande.co.uk, mdroth@linux.vnet.ibm.com On 10/07/2016 07:34 AM, Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonzini@redhat.com) wrote: >> >> >> On 06/10/2016 21:01, Dr. David Alan Gilbert wrote: >>>>>> + } else if (field->flags & VMS_LINKED) { >>>>>> + ret = field->info->get(f, addr, size, field); >>>>>> } else { >>>>>> ret = field->info->get(f, addr, size, NULL); >>>>>> >>>>>> @@ -193,6 +197,8 @@ static const char *vmfield_get_type_name(VMStateField *field) >>>>>> >>>>>> if (field->flags & VMS_STRUCT) { >>>>>> type = "struct"; >>>>>> + } else if (field->flags & VMS_LINKED) { >>>>>> + type = "linked"; >>>>>> } else if (field->info->name) { >>>>>> type = field->info->name; >>>>>> } >>>>>> @@ -327,6 +333,8 @@ void vmstate_save_state(QEMUFile *f, const VMStateDescription *vmsd, >>>>>> } >>>>>> if (field->flags & VMS_STRUCT) { >>>>>> vmstate_save_state(f, field->vmsd, addr, vmdesc_loop); >>>>>> + } else if (field->flags & VMS_LINKED) { >>>>>> + field->info->put(f, addr, size, field, vmdesc_loop); >>>>>> } else { >>>>>> field->info->put(f, addr, size, NULL, NULL); >>>>>> } >> >> Is VMS_LINKED needed at all, since the fields are unused for every >> VMStateInfo except qtailq? > > No, I think you could easily drop the VMS_LINKED and just always pass them in. It is needed if we want to use vmdesc_loop. Thanks, Jianjun > Dave > >> Paolo > -- > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK >