qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org, "Eric Farman" <farman@linux.ibm.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Leif Lindholm" <quic_llindhol@quicinc.com>,
	"Beraldo Leal" <bleal@redhat.com>,
	"Andrew Jeffery" <andrew@codeconstruct.com.au>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Marcin Juszkiewicz" <marcin.juszkiewicz@linaro.org>,
	"Pavel Dovgalyuk" <pavel.dovgaluk@ispras.ru>,
	"Thomas Huth" <thuth@redhat.com>,
	qemu-arm@nongnu.org, "Radoslaw Biernacki" <rad@semihalf.com>,
	"Yoshinori Sato" <ysato@users.sourceforge.jp>,
	"Eric Auger" <eric.auger@redhat.com>,
	"Halil Pasic" <pasic@linux.ibm.com>,
	qemu-s390x@nongnu.org,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Cédric Le Goater" <clg@kaod.org>,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Cleber Rosa" <crosa@redhat.com>, "Joel Stanley" <joel@jms.id.au>
Subject: Re: [PATCH v2 4/7] tests/avocado: drop malta yamon tests
Date: Fri, 1 Dec 2023 14:22:51 +0100	[thread overview]
Message-ID: <72ae8131-9cd3-4180-bcbb-d69f113211ac@linaro.org> (raw)
In-Reply-To: <87ttp25bqh.fsf@draig.linaro.org>

Hi Alex,

On 1/12/23 13:49, Alex Bennée wrote:
> Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> 
>> Hi Alex,
>>
>> On 1/12/23 10:36, Alex Bennée wrote:
>>> The assets are no longer available on the website so these are
>>> blocking CI.
>>>
>>
>> How are these "blocking CI"? Missing artifact wasn't be fatal,
>> is it now? Also, did the artifact cache got flushed? These tests
>> pass locally, I disagree with removing them.
>>
>> I can send a patch using YAMON_PATH like we have with RESCUE_YL_PATH,
>> but I still consider missing artifact shouldn't be an issue. We are
>> missing the point of the Avocado cache and the possibility to manually
>> add artifacts.
> 
> Sure but in this case the binaries are gone, you can't share them and no
> one else can ever run the test. At that point it just becomes dead
> weight in the repository. This doesn't stop you keeping your own branch
> where old tests live on while close to a warm cache but it does somewhat
> limit the use of the test to the wider community.

No, I still disagree. The tests/avocado/ directory started as a place
to share tests, not to add CI gating tests. That was discussed again
2 or 3 years ago, we even recommended to change from the "opt-out on CI"
policy to the "opt-in for Gating CI". Daniel suggested the Tiers
approach, having only Tier-1 gating.

I think the mistake is to consider all tests as gating.

Why don't you want to share QEMU tests in the QEMU repository?

We might have some misunderstanding on what tests/ is for, so let's
discuss...

Regards,

Phil.


  reply	other threads:[~2023-12-01 13:23 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-01  9:36 [PATCH v2 0/7] final fixes for 8.2 Alex Bennée
2023-12-01  9:36 ` [PATCH v2 1/7] gdbstub: use a better signal when we halt for IO reasons Alex Bennée
2023-12-01  9:36 ` [PATCH v2 2/7] docs/devel: rationalise unstable gitlab tests under FLAKY_TESTS Alex Bennée
2023-12-01  9:36 ` [PATCH v2 3/7] tests/avocado: drop BootLinuxConsole.test_mips_malta_cpio test Alex Bennée
2023-12-01 11:27   ` Stefan Hajnoczi
2023-12-01 13:45   ` Philippe Mathieu-Daudé
2023-12-01 13:57     ` Philippe Mathieu-Daudé
2023-12-01 13:59       ` Philippe Mathieu-Daudé
2023-12-01 15:14       ` Alex Bennée
2023-12-01  9:36 ` [PATCH v2 4/7] tests/avocado: drop malta yamon tests Alex Bennée
2023-12-01 10:24   ` Philippe Mathieu-Daudé
2023-12-01 12:49     ` Alex Bennée
2023-12-01 13:22       ` Philippe Mathieu-Daudé [this message]
2023-12-01 14:05       ` Philippe Mathieu-Daudé
2023-12-01 15:16         ` Alex Bennée
2023-12-01  9:36 ` [PATCH v2 5/7] tests/avocado: tag sbsa tests as tcg only Alex Bennée
2023-12-01 10:26   ` Philippe Mathieu-Daudé
2023-12-01  9:36 ` [PATCH v2 6/7] gitlab: build the correct microblaze target Alex Bennée
2023-12-01 10:24   ` Philippe Mathieu-Daudé
2023-12-04  7:54   ` Thomas Huth
2023-12-04 12:40     ` Alex Bennée
2023-12-04 12:43       ` Thomas Huth
2023-12-04 12:48         ` Cédric Le Goater
2023-12-04 13:32           ` Thomas Huth
2023-12-01  9:36 ` [PATCH v2 7/7] gitlab: add optional job to run flaky avocado tests Alex Bennée
2023-12-01 10:28   ` Philippe Mathieu-Daudé
2023-12-01 13:30 ` [PATCH v2 0/7] final fixes for 8.2 Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72ae8131-9cd3-4180-bcbb-d69f113211ac@linaro.org \
    --to=philmd@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=andrew@codeconstruct.com.au \
    --cc=aurelien@aurel32.net \
    --cc=bleal@redhat.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=clg@kaod.org \
    --cc=crosa@redhat.com \
    --cc=eric.auger@redhat.com \
    --cc=farman@linux.ibm.com \
    --cc=joel@jms.id.au \
    --cc=marcin.juszkiewicz@linaro.org \
    --cc=pasic@linux.ibm.com \
    --cc=pavel.dovgaluk@ispras.ru \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=quic_llindhol@quicinc.com \
    --cc=rad@semihalf.com \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).