From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8F68C28B2E for ; Tue, 11 Mar 2025 05:24:12 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1trs5V-0000dJ-41; Tue, 11 Mar 2025 01:23:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1trs5Q-0000bK-0Q; Tue, 11 Mar 2025 01:23:29 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1trs5I-0002AB-5n; Tue, 11 Mar 2025 01:23:26 -0400 Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52AKFaJa015972; Tue, 11 Mar 2025 05:23:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=6Eks2l Nv9lc2+EH3d+UDE2FdrMb8EFnK0ogG16NNO4s=; b=GD8qnmMVemfg4s6+0OQ0OU P0xQKFr2/JI+/TUTJN1habfOajbzJW8ODv0gbh2hzhvy/qNiw4wyYTdD2ZDJaVUO fin21dW6zup+0v2M0mSryR45V620bORYLBZ3LmKPDB+WumIIFNaz/YYReiFYMMje +S+OxBePqhExfY5sH+1yoDphtKXsTP6yjvw4U4G7Nj/gfJ0E2Oe2ZE3yxY8LWTkn bccBfjapPFFi5KiXYkmy98ygf9rsIb5h5HJCX/JLqbIieAsWXhpEuypoEAtidO4D BYGsgrnjaWFUVvEdc+K0KGfxCtX56NdPIZocCL+SxWULb8FKAdXYg7cy0x+H2npQ == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 45a1gp3tjy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Mar 2025 05:23:14 +0000 (GMT) Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 52B5DD8x017009; Tue, 11 Mar 2025 05:23:13 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 45a1gp3tjv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Mar 2025 05:23:13 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 52B18tHL023841; Tue, 11 Mar 2025 05:23:12 GMT Received: from smtprelay06.wdc07v.mail.ibm.com ([172.16.1.73]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4590kytgy6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Mar 2025 05:23:12 +0000 Received: from smtpav01.wdc07v.mail.ibm.com (smtpav01.wdc07v.mail.ibm.com [10.39.53.228]) by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 52B5NB4B30081590 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 11 Mar 2025 05:23:11 GMT Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 56AA058065; Tue, 11 Mar 2025 05:23:11 +0000 (GMT) Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C814C58059; Tue, 11 Mar 2025 05:23:08 +0000 (GMT) Received: from [9.109.242.165] (unknown [9.109.242.165]) by smtpav01.wdc07v.mail.ibm.com (Postfix) with ESMTP; Tue, 11 Mar 2025 05:23:08 +0000 (GMT) Message-ID: <72b6c824-7767-4dce-901f-806d291e1d98@linux.ibm.com> Date: Tue, 11 Mar 2025 10:53:07 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/7] hw/ppc: [WIP] Add Processor Dump Area offsets in Pnv SBE To: Aditya Gupta , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, Nicholas Piggin , =?UTF-8?B?RnLDqWTDqXJpYyBCYXJyYXQ=?= , Sourabh Jain , Mahesh J Salgaonkar , Hari Bathini References: <20250217071934.86131-1-adityag@linux.ibm.com> <20250217071934.86131-7-adityag@linux.ibm.com> Content-Language: en-US From: Harsh Prateek Bora In-Reply-To: <20250217071934.86131-7-adityag@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: YV82euctCVZhyyUm-BR7sRqvvhxw1eZs X-Proofpoint-ORIG-GUID: qWIkDTTFlfXgNTa-yEnJt2BhSiyi0EOk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-11_01,2025-03-07_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 clxscore=1015 mlxlogscore=999 suspectscore=0 spamscore=0 impostorscore=0 bulkscore=0 phishscore=0 malwarescore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502100000 definitions=main-2503110031 Received-SPF: pass client-ip=148.163.156.1; envelope-from=harshpb@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 2/17/25 12:49, Aditya Gupta wrote: > Add offsets for the processor state captured during MPIPL dump. > > This is incomplete. And might be implemented in future if the effort to > implement MPIPL is resumed again. Please use RFC prefix in next iteration of patch series until the patches are requested to be merged. > > Signed-off-by: Aditya Gupta > --- > hw/ppc/pnv_sbe.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/hw/ppc/pnv_sbe.c b/hw/ppc/pnv_sbe.c > index ee905df4e0a6..3b50667226b5 100644 > --- a/hw/ppc/pnv_sbe.c > +++ b/hw/ppc/pnv_sbe.c > @@ -197,6 +197,25 @@ struct mdrt_table { > __be64 padding; /* unused */ > } __packed; > > +/* > + * Processor Dump Area > + * > + * This contains the information needed for having processor > + * state captured during a platform dump. > + */ > +struct proc_dump_area { > + __be32 thread_size; /* Size of each thread register entry */ > +#define PROC_DUMP_AREA_FORMAT_P9 0x1 /* P9 format */ > + uint8_t version; > + uint8_t reserved[11]; > + __be64 alloc_addr; /* Destination memory to place register data */ > + __be32 reserved2; > + __be32 alloc_size; /* Allocated size */ > + __be64 dest_addr; /* Destination address */ > + __be32 reserved3; > + __be32 act_size; /* Actual data size */ > +} __packed; > + Above should go into pnv_sbe.h and introduce when actually get used. > static void pnv_sbe_set_host_doorbell(PnvSBE *sbe, uint64_t val) > { > val &= SBE_HOST_RESPONSE_MASK; /* Is this right? What does HW do? */ > @@ -281,6 +300,11 @@ static void pnv_mpipl_preserve_mem(void) > cpu_physical_memory_write(MDRT_TABLE_BASE, mdrt, MDRT_TABLE_SIZE); > } > > +static void pnv_mpipl_save_proc_regs(void) > +{ > + /* TODO: modify PROC_DUMP_AREA_BASE */ > +} > + > static void pnv_sbe_power9_xscom_ctrl_write(void *opaque, hwaddr addr, > uint64_t val, unsigned size) > { > @@ -307,6 +331,9 @@ static void pnv_sbe_power9_xscom_ctrl_write(void *opaque, hwaddr addr, > /* Preserve the memory locations registered for MPIPL */ > pnv_mpipl_preserve_mem(); > > + /* Save processor state */ > + pnv_mpipl_save_proc_regs(); Introduce when actually get implemented, otherwise doesnt need a separate patch for this stub. > + > /* > * TODO: Pass `mpipl` node in device tree to signify next > * boot is an MPIPL boot