From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Paul Durrant <paul@xen.org>,
Liu Zhiwei <zhiwei_liu@linux.alibaba.com>,
David Hildenbrand <david@redhat.com>,
Weiwei Li <liwei1518@gmail.com>,
xen-devel@lists.xenproject.org,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Peter Xu <peterx@redhat.com>, Nicholas Piggin <npiggin@gmail.com>,
kvm@vger.kernel.org, qemu-ppc@nongnu.org,
Alistair Francis <alistair.francis@wdc.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Harsh Prateek Bora <harshpb@linux.ibm.com>,
alex.bennee@linaro.org, qemu-riscv@nongnu.org,
manos.pitsidianakis@linaro.org,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Palmer Dabbelt <palmer@dabbelt.com>,
Daniel Henrique Barboza <danielhb413@gmail.com>,
Anthony PERARD <anthony@xenproject.org>
Subject: Re: [PATCH v2 08/16] exec/memory-internal: remove dependency on cpu.h
Date: Tue, 11 Mar 2025 08:13:46 -0700 [thread overview]
Message-ID: <72e938d4-fb4e-4be4-9a34-7b0321ee2554@linaro.org> (raw)
In-Reply-To: <9f92a783-3826-4a06-9944-0e0ec5faccc9@linaro.org>
On 3/11/25 00:26, Philippe Mathieu-Daudé wrote:
> On 11/3/25 05:08, Pierrick Bouvier wrote:
>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
>
> Missing the "why" justification we couldn't do that before.
>
>> ---
>> include/exec/memory-internal.h | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h
>> index 100c1237ac2..b729f3b25ad 100644
>> --- a/include/exec/memory-internal.h
>> +++ b/include/exec/memory-internal.h
>> @@ -20,8 +20,6 @@
>> #ifndef MEMORY_INTERNAL_H
>> #define MEMORY_INTERNAL_H
>>
>> -#include "cpu.h"
>> -
>> #ifndef CONFIG_USER_ONLY
>> static inline AddressSpaceDispatch *flatview_to_dispatch(FlatView *fv)
>> {
>
No direct dependency, but when a common code will include that (like
system/memory.c), we can't have a dependency on cpu.h anymore.
I can reorder or squash commits if you prefer.
next prev parent reply other threads:[~2025-03-11 15:14 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 4:08 [PATCH v2 00/16] make system memory API available for common code Pierrick Bouvier
2025-03-11 4:08 ` [PATCH v2 01/16] exec/tswap: target code can use TARGET_BIG_ENDIAN instead of target_words_bigendian() Pierrick Bouvier
2025-03-11 4:08 ` [PATCH v2 02/16] exec/tswap: implement {ld, st}.*_p as functions instead of macros Pierrick Bouvier
2025-03-11 19:13 ` [PATCH v2 02/16] exec/tswap: implement {ld,st}.*_p " Richard Henderson
2025-03-11 4:08 ` [PATCH v2 03/16] exec/memory_ldst: extract memory_ldst declarations from cpu-all.h Pierrick Bouvier
2025-03-11 15:09 ` Pierrick Bouvier
2025-03-11 19:15 ` Richard Henderson
2025-03-11 4:08 ` [PATCH v2 04/16] exec/memory_ldst_phys: extract memory_ldst_phys " Pierrick Bouvier
2025-03-11 19:18 ` Richard Henderson
2025-03-11 4:08 ` [PATCH v2 05/16] exec/memory.h: make devend_memop "target defines" agnostic Pierrick Bouvier
2025-03-11 19:23 ` Richard Henderson
2025-03-11 4:08 ` [PATCH v2 06/16] codebase: prepare to remove cpu.h from exec/exec-all.h Pierrick Bouvier
2025-03-11 4:08 ` [PATCH v2 07/16] exec/exec-all: remove dependency on cpu.h Pierrick Bouvier
2025-03-11 7:26 ` Philippe Mathieu-Daudé
2025-03-11 15:10 ` Pierrick Bouvier
2025-03-11 4:08 ` [PATCH v2 08/16] exec/memory-internal: " Pierrick Bouvier
2025-03-11 7:26 ` Philippe Mathieu-Daudé
2025-03-11 15:13 ` Pierrick Bouvier [this message]
2025-03-11 4:08 ` [PATCH v2 09/16] exec/ram_addr: " Pierrick Bouvier
2025-03-11 4:08 ` [PATCH v2 10/16] system/kvm: make kvm_flush_coalesced_mmio_buffer() accessible for common code Pierrick Bouvier
2025-03-11 4:08 ` [PATCH v2 11/16] exec/ram_addr: call xen_hvm_modified_memory only if xen is enabled Pierrick Bouvier
2025-03-11 7:29 ` Philippe Mathieu-Daudé
2025-03-11 15:16 ` Pierrick Bouvier
2025-03-11 4:08 ` [PATCH v2 12/16] hw/xen: add stubs for various functions Pierrick Bouvier
2025-03-11 4:08 ` [PATCH v2 13/16] system/physmem: compilation unit is now common to all targets Pierrick Bouvier
2025-03-11 4:08 ` [PATCH v2 14/16] include/exec/memory: extract devend_big_endian from devend_memop Pierrick Bouvier
2025-03-11 7:36 ` Philippe Mathieu-Daudé
2025-03-11 15:20 ` Pierrick Bouvier
2025-03-11 15:24 ` Pierrick Bouvier
2025-03-11 19:32 ` Richard Henderson
2025-03-11 4:08 ` [PATCH v2 15/16] system/memory: make compilation unit common Pierrick Bouvier
2025-03-11 19:33 ` Richard Henderson
2025-03-11 4:08 ` [PATCH v2 16/16] system/ioport: " Pierrick Bouvier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72e938d4-fb4e-4be4-9a34-7b0321ee2554@linaro.org \
--to=pierrick.bouvier@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=anthony@xenproject.org \
--cc=danielhb413@gmail.com \
--cc=david@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=harshpb@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=liwei1518@gmail.com \
--cc=manos.pitsidianakis@linaro.org \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=ysato@users.sourceforge.jp \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).