From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Helge Deller <deller@gmx.de>, Anton Johansson <anjo@rev.ng>
Subject: Re: [PATCH v2 5/6] hw/hppa: Move CPU::cmdline_or_bootorder -> Machine::boot_info.gr24
Date: Fri, 10 Oct 2025 10:57:55 -0700 [thread overview]
Message-ID: <72ed8f25-8bc4-4d9c-9e7e-1942a1f7c020@linaro.org> (raw)
In-Reply-To: <20251010061836.45739-6-philmd@linaro.org>
On 10/9/25 23:18, Philippe Mathieu-Daudé wrote:
> } else {
> /* When booting via firmware, tell firmware if we want interactive
> - * mode (interactive_mode=1), and to boot from CD (cmdline_or_bootorder='d')
> - * or hard disc (cmdline_or_bootorder='c').
> + * mode (interactive_mode=1), and to boot from CD (bootorder='d')
> + * or hard disc (bootorder='c').
> */
Again there is no bootorder variable, so gr24 might be better.
> @@ -685,7 +686,6 @@ static void hppa_machine_reset(MachineState *ms, ResetType type)
> memset(&hms->boot_info, 0, sizeof(hms->boot_info));
> cpu[0]->env.initrd_base = 0;
> cpu[0]->env.initrd_end = 0;
> - cpu[0]->env.cmdline_or_bootorder = 'c';
> }
You need to retain this store, but adjust to boot_info.gr24.
r~
next prev parent reply other threads:[~2025-10-10 17:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-10 6:18 [PATCH v2 0/6] hw/hppa: Clarify machine variables and move them out of CPUArchState Philippe Mathieu-Daudé
2025-10-10 6:18 ` [PATCH v2 1/6] hw/hppa: Convert type_init() -> DEFINE_TYPES() Philippe Mathieu-Daudé
2025-10-10 6:18 ` [PATCH v2 2/6] hw/hppa: Factor QOM HPPA_COMMON_MACHINE out Philippe Mathieu-Daudé
2025-10-10 6:18 ` [PATCH v2 3/6] hw/hppa: Reduce variables scope in common_init() Philippe Mathieu-Daudé
2025-10-10 17:23 ` Richard Henderson
2025-10-10 6:18 ` [PATCH v2 4/6] hw/hppa: Move CPU::kernel_entry -> Machine::boot_info.gr25 Philippe Mathieu-Daudé
2025-10-10 17:54 ` Richard Henderson
2025-10-10 6:18 ` [PATCH v2 5/6] hw/hppa: Move CPU::cmdline_or_bootorder -> Machine::boot_info.gr24 Philippe Mathieu-Daudé
2025-10-10 17:57 ` Richard Henderson [this message]
2025-10-10 6:18 ` [PATCH v2 6/6] hw/hppa: Move CPU::initrd_base/end -> Machine::boot_info.gr22/23 Philippe Mathieu-Daudé
2025-10-10 17:59 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72ed8f25-8bc4-4d9c-9e7e-1942a1f7c020@linaro.org \
--to=richard.henderson@linaro.org \
--cc=anjo@rev.ng \
--cc=deller@gmx.de \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).