qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Volker Rümelin" <vr_qemu@t-online.de>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>
Cc: Bernhard Beschow <shentey@gmail.com>,
	Stefan Weil <sw@weilnetz.de>,
	qemu-devel@nongnu.org
Subject: SDL2: fix handling of the AltGr key on Windows again
Date: Tue, 18 Apr 2023 08:26:54 +0200	[thread overview]
Message-ID: <72f7af6f-d22f-c347-db88-b8d9a769d6a3@t-online.de> (raw)

Based-on: <20230417192139.43263-1-shentey@gmail.com>
("[PATCH v2 0/2] SDL2 usability fixes")

Windows sends an extra left control key up/down input event for every 
right alt key up/down input event for keyboards with international 
layout. Since commit 830473455f ("ui/sdl2: fix handling of AltGr key on 
Windows") QEMU uses a Windows low level keyboard hook procedure to 
reliably filter out the special left control key and to grab the 
keyboard on Windows.

SDL2 version 2.0.16 introduced its own Windows low level keyboard hook 
procedure to grab the keyboard. When enabled with a grabbed keyboard, 
this disables the special left control key filter and handling of the 
AltGr key on Windows is broken again.

This patch fixes handling of the AltGr key on Windows with international 
keyboard layout.

Volker Rümelin (1):
   ui/sdl2: disable SDL_HINT_GRAB_KEYBOARD on Windows

  ui/sdl2.c | 3 +++
  1 file changed, 3 insertions(+)

-- 
2.35.3



             reply	other threads:[~2023-04-18  6:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-18  6:26 Volker Rümelin [this message]
2023-04-18  6:28 ` [PATCH] ui/sdl2: disable SDL_HINT_GRAB_KEYBOARD on Windows Volker Rümelin
2023-04-18  7:36   ` Thomas Huth
2023-04-18 18:09   ` Bernhard Beschow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72f7af6f-d22f-c347-db88-b8d9a769d6a3@t-online.de \
    --to=vr_qemu@t-online.de \
    --cc=kraxel@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=shentey@gmail.com \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).