From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB5CEC388F9 for ; Thu, 19 Nov 2020 19:49:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D8E8C22256 for ; Thu, 19 Nov 2020 19:49:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="V4xvjqbf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8E8C22256 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39176 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfpvi-0005Tx-40 for qemu-devel@archiver.kernel.org; Thu, 19 Nov 2020 14:49:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49144) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfpv1-0004xh-OP for qemu-devel@nongnu.org; Thu, 19 Nov 2020 14:48:36 -0500 Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]:36145) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kfpur-0007ru-9V for qemu-devel@nongnu.org; Thu, 19 Nov 2020 14:48:30 -0500 Received: by mail-pg1-x52a.google.com with SMTP id t21so5187831pgl.3 for ; Thu, 19 Nov 2020 11:48:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8/vnUitJQixktGOB5OjyggdicXasxT2Wjam4/pgqxs4=; b=V4xvjqbfFo3TWuu7XmCy05ahWo48cQGkBkMBVzAK36ES+EuUniq+ybrD/7DxGG6msx A40yAiObZf4pwPtsp4s2xczld2j4/2nEIqUq7asMq+ti4fiKoS7NRPR6yaFn7gNA2toV dy7Edhrr2GIxC7zgx/tLYdw9CXeEJktwr+kTXYxDcHRASlNoa4eFJDvR95v1vaU3vCPf 76h3ElKnWtIFTnnCzJHki8orK3big0/DGl9Q8hc4miJ7oQ6NoMNKK16woDyHtPDqn+dE 0A87Ggn/GY0O0ah9ugyxhll/vleDmxgCw714UIYzLd88PP2qgQ/qIdiwXq1cFkhQTJoz Z0XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8/vnUitJQixktGOB5OjyggdicXasxT2Wjam4/pgqxs4=; b=bgt8RlFaV4qKVi8HT/TVp3+Uk/MkxCpA33JpsavyMYgaf54EAIRjxyf98K43k3Fmhd OBaxRNqFwoen80A6XDEVLWag/h4oFwgCgeLwfQu1Cy5trCUMd2LQ+fWF3KaNWUR4zM48 f80PeP2wzyCSNBYt0wk3S7KgCeZh9Zrw9wwGXW1+jytLBwDUy1WqBBPCE02s/7dMQd83 wvnnl/YjH0UoTEWWK2c+fJH1ulFDlxIjvJmaslHs147rsu0vaBW3crU7H+M0rZ7GyjGW VM/yoX01dhOVCwksvKjXX9s8dHARKvOjb/oax8rFlbRWLlle4MRDm6gn5golPrSjxMY9 s9CQ== X-Gm-Message-State: AOAM5335FgJxLex5AmTt60UDfL5cGRlxBwKELkx5ofzOyDOGnGbygJJ1 9ouX2+XKMlpxAlq94biQpT7/TA== X-Google-Smtp-Source: ABdhPJwDhPbsDGGr07f4wbS62i2wBAca/ni/cPjw1g9Xa3zwx5b/B2DREV7fdSnCPF6nu8WmaReCIA== X-Received: by 2002:a17:90a:34c5:: with SMTP id m5mr6142381pjf.184.1605815302820; Thu, 19 Nov 2020 11:48:22 -0800 (PST) Received: from [192.168.1.11] ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id k17sm476727pji.50.2020.11.19.11.48.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Nov 2020 11:48:22 -0800 (PST) Subject: Re: [RFC 02/15] target/riscv: rvb: count leading/trailing zeros To: frank.chang@sifive.com, qemu-devel@nongnu.org, qemu-riscv@nongnu.org References: <20201118083044.13992-1-frank.chang@sifive.com> <20201118083044.13992-3-frank.chang@sifive.com> From: Richard Henderson Message-ID: <72fcab50-3dfe-e970-9dc4-098b6ab8f675@linaro.org> Date: Thu, 19 Nov 2020 11:48:20 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201118083044.13992-3-frank.chang@sifive.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::52a; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastian Koppelmann , Kito Cheng , Alistair Francis , Palmer Dabbelt , Sagar Karandikar Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/18/20 12:29 AM, frank.chang@sifive.com wrote: > +# *** RV64B Standard Extension (in addition to RV32B) *** > +clzw 011000000000 ..... 001 ..... 0011011 @r2 > +ctzw 011000000001 ..... 001 ..... 0011011 @r2 Oh, one more thing. In the draft, the top decode bits are split into two fields: 7+5. It would be easier to read all of these if you did the same here. r~