From: Eric Farman <farman@linux.ibm.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
mrezanin@redhat.com,
"Richard Henderson" <richard.henderson@linaro.org>,
"Cédric Le Goater" <clegoate@redhat.com>,
"Janosch Frank" <frankja@linux.ibm.com>,
"Jason J . Herne" <jjherne@linux.ibm.com>,
"Marc Hartmayer" <mhartmay@linux.ibm.com>,
"Claudio Imbrenda" <imbrenda@linux.ibm.com>
Subject: Re: [PATCH v2 3/4] pc-bios/s390-ccw: Move the stack array into start.S
Date: Tue, 27 Jun 2023 06:14:12 -0400 [thread overview]
Message-ID: <73106978c5a4bfbba7129dfca1ccaef41bda529d.camel@linux.ibm.com> (raw)
In-Reply-To: <20230627074703.99608-4-thuth@redhat.com>
On Tue, 2023-06-27 at 09:47 +0200, Thomas Huth wrote:
> The stack array is only referenced from the start-up code (which is
> shared between the s390-ccw.img and the s390-netboot.img), but it is
> currently declared twice, once in main.c and once in netmain.c.
> It makes more sense to declare this in start.S instead - which will
> also be helpful in the next patch, since we need to mention the .bss
> section in start.S in that patch.
>
> While we're at it, let's also drop the huge alignment of the stack,
> since there is no technical requirement for aligning it to page
> boundaries.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> pc-bios/s390-ccw/s390-ccw.h | 1 -
> pc-bios/s390-ccw/main.c | 1 -
> pc-bios/s390-ccw/netmain.c | 1 -
> pc-bios/s390-ccw/start.S | 6 ++++++
> 4 files changed, 6 insertions(+), 3 deletions(-)
Reviewed-by: Eric Farman <farman@linux.ibm.com>
next prev parent reply other threads:[~2023-06-27 10:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 7:46 [PATCH v2 0/4] pc-bios/s390-ccw: Fixes and improvements for start.S Thomas Huth
2023-06-27 7:47 ` [PATCH v2 1/4] pc-bios/s390-ccw: Fix indentation in start.S Thomas Huth
2023-06-27 9:15 ` Philippe Mathieu-Daudé
2023-06-27 9:27 ` Claudio Imbrenda
2023-06-27 10:01 ` Eric Farman
2023-06-27 7:47 ` [PATCH v2 2/4] pc-bios/s390-ccw: Provide space for initial stack frame " Thomas Huth
2023-06-27 8:26 ` Marc Hartmayer
2023-06-27 9:14 ` Philippe Mathieu-Daudé
2023-06-27 10:02 ` Eric Farman
2023-06-27 11:55 ` Thomas Huth
2023-06-27 9:27 ` Claudio Imbrenda
2023-06-27 7:47 ` [PATCH v2 3/4] pc-bios/s390-ccw: Move the stack array into start.S Thomas Huth
2023-06-27 9:28 ` Claudio Imbrenda
2023-06-27 10:14 ` Eric Farman [this message]
2023-06-27 15:47 ` Thomas Huth
2023-06-27 7:47 ` [PATCH v2 4/4] pc-bios/s390-ccw: Don't use __bss_start with the "larl" instruction Thomas Huth
2023-06-27 9:29 ` Claudio Imbrenda
2023-06-27 10:54 ` Thomas Huth
2023-06-27 10:44 ` Eric Farman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73106978c5a4bfbba7129dfca1ccaef41bda529d.camel@linux.ibm.com \
--to=farman@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=clegoate@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=jjherne@linux.ibm.com \
--cc=mhartmay@linux.ibm.com \
--cc=mrezanin@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).