From: "Cédric Le Goater" <clg@kaod.org>
To: Jamin Lin <jamin_lin@aspeedtech.com>,
Peter Maydell <peter.maydell@linaro.org>,
Steven Lee <steven_lee@aspeedtech.com>,
Troy Lee <leetroy@gmail.com>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Joel Stanley <joel@jms.id.au>,
"open list:All patches CC here" <qemu-devel@nongnu.org>,
"open list:ASPEED BMCs" <qemu-arm@nongnu.org>
Cc: <troy_lee@aspeedtech.com>, <kane_chen@aspeedtech.com>
Subject: Re: [SPAM] [PATCH v3 00/30] Split AST2400, AST2500, AST2600, AST2700 and AST1030 SoC machines into separate source files for maintainability
Date: Mon, 3 Nov 2025 11:23:31 +0100 [thread overview]
Message-ID: <731294a8-bc5d-4cc8-be7e-1354db393d0f@kaod.org> (raw)
In-Reply-To: <20251103092801.1282602-1-jamin_lin@aspeedtech.com>
Jamin,
On 11/3/25 10:27, Jamin Lin wrote:
> v1:
> 1. Split each Aspeed machine into its own source file for better
> readability and maintainability:
> - Quanta-Q71L
> - Supermicro X11
> - Palmetto
> - Bletchley
> - fby35 BMC
> - Facebook Fuji
> - QCOM Firework
> - QCOM DC-SCM V1
> - GB200NVL
> - Rainier
> - Catalina
> - AST2600 EVB
> - AST2700 EVB
> - AST1030 EVB
> 2. Make aspeed_machine_ast2600_class_emmc_init() a shared API
> for eMMC boot setup.
> 3. Promote connect_serial_hds_to_uarts() to a public machine API
> for reuse across platforms.
>
> v2:
> 1. Restore ASPEED_RAM_SIZE() macro
>
> v3:
> 1. Merged AST2500 SoC machine changes into this patch series.
> Split each AST2500 machine into its own source file:
> - FP5280G2
> - G220A
> - Tiogapass
> - YosemiteV2
> - Witherspoon
> - Sonorapass
> - Romulus
> - Supermicro X11SPI
> - AST2500 EVB
> 2. Renamed common API functions with the aspeed_ prefix for consistency.
> 3. Added detailed descriptions for the common API functions.
>
> Jamin Lin (30):
> hw/arm/aspeed: Move AspeedMachineState definition to common header for
> reuse
> hw/arm/aspeed: Make aspeed_machine_class_init_cpus_defaults() globally
> accessible
> hw/arm/aspeed: Export and rename create_pca9552() for reuse
> hw/arm/aspeed: Rename and export create_pca9554() as
> aspeed_create_pca9554()
> hw/arm/aspeed: Split FP5280G2 machine into a separate source file for
> maintenance
> hw/arm/aspeed: Split G220A machine into a separate source file for
> better maintenance
> hw/arm/aspeed: Split Tiogapass machine into a separate source file for
> cleanup
> hw/arm/aspeed: Split YosemiteV2 machine into a separate source file
> for maintainability
> hw/arm/aspeed: Split Witherspoon machine into a separate source file
> for maintainability
> hw/arm/aspeed: Split Sonorapass machine into a separate source file
> for maintainability
> hw/arm/aspeed: Split Romulus machine into a separate source file for
> maintainability
> hw/arm/aspeed: Split Supermicro X11SPI machine into a separate file
> for maintainability
> hw/arm/aspeed: Split AST2500 EVB machine into a separate source file
> for maintainability
> hw/arm/aspeed: Split Quanta-Q71L machine into a separate source file
> for maintainability
> hw/arm/aspeed: Split Supermicro X11 machine into a separate source
> file for maintainability
> hw/arm/aspeed: Split Palmetto machine into a separate source file for
> maintainability
> hw/arm/aspeed: Move ASPEED_RAM_SIZE() macro to common header for reuse
> hw/arm/aspeed: Split Bletchley machine into a separate source file for
> maintainability
> hw/arm/aspeed: Split FBY35 BMC machine into a separate source file for
> maintainability
> hw/arm/aspeed: Split Fuji machine into a separate source file for
> maintainability
> hw/arm/aspeed: Split QCOM Firework machine into a separate source file
> for maintainability
> hw/arm/aspeed: Split QCOM DC-SCM V1 machine into a separate source
> file for maintainability
> hw/arm/aspeed: Make aspeed_machine_ast2600_class_emmc_init() a common
> API for eMMC boot setup
> hw/arm/aspeed: Split GB200NVL machine into a separate source file for
> maintainability
> hw/arm/aspeed: Split Rainier machine into a separate source file for
> maintainability
> hw/arm/aspeed: Split Catalina machine into a separate source file for
> maintainability
> hw/arm/aspeed: Split AST2600 EVB machine into a separate source file
> for maintainability
> hw/arm/aspeed: Split AST2700 EVB machine into a separate source file
> for maintainability
> hw/arm/aspeed: Rename and export connect_serial_hds_to_uarts() as
> aspeed_connect_serial_hds_to_uarts()
> hw/arm/aspeed: Split AST1030 EVB machine into a separate source file
> for maintainability
>
> hw/arm/aspeed_eeprom.h | 32 -
> include/hw/arm/aspeed.h | 79 +
> hw/arm/aspeed.c | 1678 +--------------------
> hw/arm/aspeed_ast10x0_evb.c | 109 ++
> hw/arm/aspeed_ast2400_palmetto.c | 81 +
> hw/arm/aspeed_ast2400_quanta-q71l.c | 87 ++
> hw/arm/aspeed_ast2400_supermicrox11.c | 82 +
> hw/arm/aspeed_ast2500_evb.c | 68 +
> hw/arm/aspeed_ast2500_fp5280g2.c | 89 ++
> hw/arm/aspeed_ast2500_g220a.c | 93 ++
> hw/arm/aspeed_ast2500_romulus.c | 63 +
> hw/arm/aspeed_ast2500_sonorapass.c | 103 ++
> hw/arm/aspeed_ast2500_supermicro-x11spi.c | 78 +
> hw/arm/aspeed_ast2500_tiogapass.c | 91 ++
> hw/arm/aspeed_ast2500_witherspoon.c | 113 ++
> hw/arm/aspeed_ast2500_yosemitev2.c | 92 ++
> hw/arm/aspeed_ast2600_bletchley.c | 98 ++
> hw/arm/aspeed_ast2600_catalina.c | 226 +++
> hw/arm/aspeed_ast2600_evb.c | 66 +
> hw/arm/aspeed_ast2600_fby35.c | 179 +++
> hw/arm/aspeed_ast2600_fuji.c | 141 ++
> hw/arm/aspeed_ast2600_gb200nvl.c | 112 ++
> hw/arm/aspeed_ast2600_qcom-dc-scm-v1.c | 56 +
> hw/arm/aspeed_ast2600_qcom-firework.c | 92 ++
> hw/arm/aspeed_ast2600_rainier.c | 199 +++
> hw/arm/aspeed_ast27x0_evb.c | 89 ++
> hw/arm/aspeed_eeprom.c | 192 ---
> hw/arm/meson.build | 24 +-
> 28 files changed, 2515 insertions(+), 1897 deletions(-)
> delete mode 100644 hw/arm/aspeed_eeprom.h
> create mode 100644 hw/arm/aspeed_ast10x0_evb.c
> create mode 100644 hw/arm/aspeed_ast2400_palmetto.c
> create mode 100644 hw/arm/aspeed_ast2400_quanta-q71l.c
> create mode 100644 hw/arm/aspeed_ast2400_supermicrox11.c
> create mode 100644 hw/arm/aspeed_ast2500_evb.c
> create mode 100644 hw/arm/aspeed_ast2500_fp5280g2.c
> create mode 100644 hw/arm/aspeed_ast2500_g220a.c
> create mode 100644 hw/arm/aspeed_ast2500_romulus.c
> create mode 100644 hw/arm/aspeed_ast2500_sonorapass.c
> create mode 100644 hw/arm/aspeed_ast2500_supermicro-x11spi.c
> create mode 100644 hw/arm/aspeed_ast2500_tiogapass.c
> create mode 100644 hw/arm/aspeed_ast2500_witherspoon.c
> create mode 100644 hw/arm/aspeed_ast2500_yosemitev2.c
> create mode 100644 hw/arm/aspeed_ast2600_bletchley.c
> create mode 100644 hw/arm/aspeed_ast2600_catalina.c
> create mode 100644 hw/arm/aspeed_ast2600_evb.c
> create mode 100644 hw/arm/aspeed_ast2600_fby35.c
> create mode 100644 hw/arm/aspeed_ast2600_fuji.c
> create mode 100644 hw/arm/aspeed_ast2600_gb200nvl.c
> create mode 100644 hw/arm/aspeed_ast2600_qcom-dc-scm-v1.c
> create mode 100644 hw/arm/aspeed_ast2600_qcom-firework.c
> create mode 100644 hw/arm/aspeed_ast2600_rainier.c
> create mode 100644 hw/arm/aspeed_ast27x0_evb.c
> delete mode 100644 hw/arm/aspeed_eeprom.c
>
It looks good.
Could you please maintain :
Copyright 2016 IBM Corp.
in the new files since the code is copied from aspeed.c.
Thanks,
C.
next prev parent reply other threads:[~2025-11-03 10:25 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 9:27 [PATCH v3 00/30] Split AST2400, AST2500, AST2600, AST2700 and AST1030 SoC machines into separate source files for maintainability Jamin Lin via
2025-11-03 9:27 ` [PATCH v3 01/30] hw/arm/aspeed: Move AspeedMachineState definition to common header for reuse Jamin Lin via
2025-11-03 9:27 ` [PATCH v3 02/30] hw/arm/aspeed: Make aspeed_machine_class_init_cpus_defaults() globally accessible Jamin Lin via
2025-11-03 9:59 ` [SPAM] " Cédric Le Goater
2025-11-03 9:27 ` [PATCH v3 03/30] hw/arm/aspeed: Export and rename create_pca9552() for reuse Jamin Lin via
2025-11-03 9:59 ` [SPAM] " Cédric Le Goater
2025-11-03 10:21 ` Cédric Le Goater
2025-11-04 2:01 ` Jamin Lin
2025-11-03 9:27 ` [PATCH v3 04/30] hw/arm/aspeed: Rename and export create_pca9554() as aspeed_create_pca9554() Jamin Lin via
2025-11-03 10:14 ` [SPAM] " Cédric Le Goater
2025-11-03 9:27 ` [PATCH v3 05/30] hw/arm/aspeed: Split FP5280G2 machine into a separate source file for maintenance Jamin Lin via
2025-11-03 9:27 ` [PATCH v3 06/30] hw/arm/aspeed: Split G220A machine into a separate source file for better maintenance Jamin Lin via
2025-11-03 9:27 ` [PATCH v3 07/30] hw/arm/aspeed: Split Tiogapass machine into a separate source file for cleanup Jamin Lin via
2025-11-03 9:27 ` [PATCH v3 08/30] hw/arm/aspeed: Split YosemiteV2 machine into a separate source file for maintainability Jamin Lin via
2025-11-03 9:27 ` [PATCH v3 09/30] hw/arm/aspeed: Split Witherspoon " Jamin Lin via
2025-11-03 9:27 ` [PATCH v3 10/30] hw/arm/aspeed: Split Sonorapass " Jamin Lin via
2025-11-03 9:27 ` [PATCH v3 11/30] hw/arm/aspeed: Split Romulus " Jamin Lin via
2025-11-03 9:27 ` [PATCH v3 12/30] hw/arm/aspeed: Split Supermicro X11SPI machine into a separate " Jamin Lin via
2025-11-03 9:27 ` [PATCH v3 13/30] hw/arm/aspeed: Split AST2500 EVB machine into a separate source " Jamin Lin via
2025-11-03 9:27 ` [PATCH v3 14/30] hw/arm/aspeed: Split Quanta-Q71L " Jamin Lin via
2025-11-03 9:27 ` [PATCH v3 15/30] hw/arm/aspeed: Split Supermicro X11 " Jamin Lin via
2025-11-03 9:27 ` [PATCH v3 16/30] hw/arm/aspeed: Split Palmetto " Jamin Lin via
2025-11-03 9:27 ` [PATCH v3 17/30] hw/arm/aspeed: Move ASPEED_RAM_SIZE() macro to common header for reuse Jamin Lin via
2025-11-03 9:27 ` [PATCH v3 18/30] hw/arm/aspeed: Split Bletchley machine into a separate source file for maintainability Jamin Lin via
2025-11-03 9:27 ` [PATCH v3 19/30] hw/arm/aspeed: Split FBY35 BMC " Jamin Lin via
2025-11-03 9:27 ` [PATCH v3 20/30] hw/arm/aspeed: Split Fuji " Jamin Lin via
2025-11-03 9:27 ` [PATCH v3 21/30] hw/arm/aspeed: Split QCOM Firework " Jamin Lin via
2025-11-03 9:27 ` [PATCH v3 22/30] hw/arm/aspeed: Split QCOM DC-SCM V1 " Jamin Lin via
2025-11-03 9:27 ` [PATCH v3 23/30] hw/arm/aspeed: Make aspeed_machine_ast2600_class_emmc_init() a common API for eMMC boot setup Jamin Lin via
2025-11-03 9:27 ` [PATCH v3 24/30] hw/arm/aspeed: Split GB200NVL machine into a separate source file for maintainability Jamin Lin via
2025-11-03 9:27 ` [PATCH v3 25/30] hw/arm/aspeed: Split Rainier " Jamin Lin via
2025-11-03 9:27 ` [PATCH v3 26/30] hw/arm/aspeed: Split Catalina " Jamin Lin via
2025-11-03 9:27 ` [PATCH v3 27/30] hw/arm/aspeed: Split AST2600 EVB " Jamin Lin via
2025-11-03 9:27 ` [PATCH v3 28/30] hw/arm/aspeed: Split AST2700 " Jamin Lin via
2025-11-03 9:27 ` [PATCH v3 29/30] hw/arm/aspeed: Rename and export connect_serial_hds_to_uarts() as aspeed_connect_serial_hds_to_uarts() Jamin Lin via
2025-11-03 9:27 ` [PATCH v3 30/30] hw/arm/aspeed: Split AST1030 EVB machine into a separate source file for maintainability Jamin Lin via
2025-11-03 10:23 ` Cédric Le Goater [this message]
2025-11-04 2:02 ` [SPAM] [PATCH v3 00/30] Split AST2400, AST2500, AST2600, AST2700 and AST1030 SoC machines into separate source files " Jamin Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=731294a8-bc5d-4cc8-be7e-1354db393d0f@kaod.org \
--to=clg@kaod.org \
--cc=andrew@codeconstruct.com.au \
--cc=jamin_lin@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=kane_chen@aspeedtech.com \
--cc=leetroy@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=steven_lee@aspeedtech.com \
--cc=troy_lee@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).