qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH RFC 0/5] target/s390x: introduce internal.h and cleanup cpu.h
@ 2017-08-11  7:46 David Hildenbrand
  2017-08-11  7:46 ` [Qemu-devel] [PATCH RFC 1/5] target/s390x: introduce internal.h David Hildenbrand
                   ` (6 more replies)
  0 siblings, 7 replies; 29+ messages in thread
From: David Hildenbrand @ 2017-08-11  7:46 UTC (permalink / raw)
  To: qemu-devel; +Cc: rth, Aurelien Jarno, thuth, cohuck, david, borntraeger

cpu.h is accessed outside of target/s390x. It should only contain
what is expected to be accessed outside of this folder. Therefore, create
internal.h and move a lot to that file.

While doing that, I noticed that a lot of function prototypes not
available with CONFIG_USER_ONLY are not protected by CONFIG_USER_ONLY.

As these CONFIG_USER_ONLY are in general ugly, I decided to minimize
them to the bare minimum :]. Do we care? I dropped it wherever possible.

My compiler doesn't bail out, so let's see what the bot says.

There is still a lot to clean up (e.g. do we want kvm-stub.c ?). This is
the first step.

David Hildenbrand (5):
  target/s390x: introduce internal.h
  target/s390x: move a couple of functions to cpu.c
  s390x: avoid calling kvm_ functions outside of target/s390x/
  target/s390x: remove all CONFIG_KVM from cpu.h
  target/s390x: cleanup cpu.h

 hw/s390x/s390-virtio-ccw.c |   4 +-
 target/s390x/arch_dump.c   |   1 +
 target/s390x/cc_helper.c   |   1 +
 target/s390x/cpu.c         |  87 ++++++
 target/s390x/cpu.h         | 759 +++++----------------------------------------
 target/s390x/cpu_models.c  |   1 +
 target/s390x/diag.c        |   1 +
 target/s390x/excp_helper.c |   1 +
 target/s390x/fpu_helper.c  |   1 +
 target/s390x/gdbstub.c     |   1 +
 target/s390x/helper.c      |   1 +
 target/s390x/int_helper.c  |   1 +
 target/s390x/internal.h    | 612 ++++++++++++++++++++++++++++++++++++
 target/s390x/interrupt.c   |   1 +
 target/s390x/ioinst.c      |   1 +
 target/s390x/kvm.c         |   1 +
 target/s390x/machine.c     |   1 +
 target/s390x/mem_helper.c  |   1 +
 target/s390x/misc_helper.c |   1 +
 target/s390x/mmu_helper.c  |   1 +
 target/s390x/translate.c   |   1 +
 21 files changed, 787 insertions(+), 692 deletions(-)
 create mode 100644 target/s390x/internal.h

-- 
2.9.4

^ permalink raw reply	[flat|nested] 29+ messages in thread

end of thread, other threads:[~2017-08-11 18:42 UTC | newest]

Thread overview: 29+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-11  7:46 [Qemu-devel] [PATCH RFC 0/5] target/s390x: introduce internal.h and cleanup cpu.h David Hildenbrand
2017-08-11  7:46 ` [Qemu-devel] [PATCH RFC 1/5] target/s390x: introduce internal.h David Hildenbrand
2017-08-11 13:15   ` Richard Henderson
2017-08-11 13:21     ` David Hildenbrand
2017-08-11 14:00   ` Thomas Huth
2017-08-11 14:21     ` David Hildenbrand
2017-08-11 14:39       ` Thomas Huth
2017-08-11 16:11         ` David Hildenbrand
2017-08-11 16:29           ` Thomas Huth
2017-08-11 14:14   ` Thomas Huth
2017-08-11 14:16     ` David Hildenbrand
2017-08-11  7:46 ` [Qemu-devel] [PATCH RFC 2/5] target/s390x: move a couple of functions to cpu.c David Hildenbrand
2017-08-11 13:17   ` Richard Henderson
2017-08-11 14:09   ` Thomas Huth
2017-08-11  7:46 ` [Qemu-devel] [PATCH RFC 3/5] s390x: avoid calling kvm_ functions outside of target/s390x/ David Hildenbrand
2017-08-11 13:18   ` Richard Henderson
2017-08-11 14:19   ` Thomas Huth
2017-08-11  7:46 ` [Qemu-devel] [PATCH RFC 4/5] target/s390x: remove all CONFIG_KVM from cpu.h David Hildenbrand
2017-08-11 13:19   ` Richard Henderson
2017-08-11 14:19   ` Thomas Huth
2017-08-11 16:11     ` David Hildenbrand
2017-08-11 17:18     ` Richard Henderson
2017-08-11 18:42       ` David Hildenbrand
2017-08-11  7:46 ` [Qemu-devel] [PATCH RFC 5/5] target/s390x: cleanup cpu.h David Hildenbrand
2017-08-11 13:20   ` Richard Henderson
2017-08-11  8:04 ` [Qemu-devel] [PATCH RFC 0/5] target/s390x: introduce internal.h and " no-reply
2017-08-11  8:53   ` David Hildenbrand
2017-08-11 15:15 ` Cornelia Huck
2017-08-11 15:30   ` David Hildenbrand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).