From: Laurent Vivier <laurent@vivier.eu>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, qemu-devel@nongnu.org
Subject: Re: [PATCH v2 2/3] target/m68k: reformat m68k_features enum
Date: Mon, 8 Mar 2021 18:33:20 +0100 [thread overview]
Message-ID: <732e8cd1-60d3-915a-0c8c-dff5d9c20449@vivier.eu> (raw)
In-Reply-To: <20210308121155.2476-3-mark.cave-ayland@ilande.co.uk>
Le 08/03/2021 à 13:11, Mark Cave-Ayland a écrit :
> Move the feature comment from after the feature name to the preceding line to
> allow for longer feature names and descriptions without hitting the 80
> character line limit.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
> target/m68k/cpu.h | 66 +++++++++++++++++++++++++++++++----------------
> 1 file changed, 44 insertions(+), 22 deletions(-)
>
> diff --git a/target/m68k/cpu.h b/target/m68k/cpu.h
> index 7c3feeaf8a..ce558e9b03 100644
> --- a/target/m68k/cpu.h
> +++ b/target/m68k/cpu.h
> @@ -475,36 +475,58 @@ void do_m68k_semihosting(CPUM68KState *env, int nr);
> */
>
> enum m68k_features {
> - M68K_FEATURE_M68000, /* Base m68k instruction set */
> + /* Base m68k instruction set */
> + M68K_FEATURE_M68000,
> M68K_FEATURE_M68010,
> M68K_FEATURE_M68020,
> M68K_FEATURE_M68030,
> M68K_FEATURE_M68040,
> M68K_FEATURE_M68060,
> - M68K_FEATURE_CF_ISA_A, /* Base Coldfire set Rev A. */
> - M68K_FEATURE_CF_ISA_B, /* (ISA B or C). */
> - M68K_FEATURE_CF_ISA_APLUSC, /* BIT/BITREV, FF1, STRLDSR (ISA A+ or C). */
> - M68K_FEATURE_BRAL, /* BRA with Long branch. (680[2346]0, ISA A+ or B). */
> + /* Base Coldfire set Rev A. */
> + M68K_FEATURE_CF_ISA_A,
> + /* (ISA B or C). */
> + M68K_FEATURE_CF_ISA_B,
> + /* BIT/BITREV, FF1, STRLDSR (ISA A+ or C). */
> + M68K_FEATURE_CF_ISA_APLUSC,
> + /* BRA with Long branch. (680[2346]0, ISA A+ or B). */
> + M68K_FEATURE_BRAL,
> M68K_FEATURE_CF_FPU,
> M68K_FEATURE_CF_MAC,
> M68K_FEATURE_CF_EMAC,
> - M68K_FEATURE_CF_EMAC_B, /* Revision B EMAC (dual accumulate). */
> - M68K_FEATURE_USP, /* User Stack Pointer. (680[012346]0, ISA A+, B or C).*/
> - M68K_FEATURE_MSP, /* Master Stack Pointer. (680[234]0) */
> - M68K_FEATURE_EXT_FULL, /* 68020+ full extension word. */
> - M68K_FEATURE_WORD_INDEX, /* word sized address index registers. */
> - M68K_FEATURE_SCALED_INDEX, /* scaled address index registers. */
> - M68K_FEATURE_LONG_MULDIV, /* 32 bit mul/div. (680[2346]0, and CPU32) */
> - M68K_FEATURE_QUAD_MULDIV, /* 64 bit mul/div. (680[2346]0, and CPU32) */
> - M68K_FEATURE_BCCL, /* Bcc with Long branches. (680[2346]0, and CPU32) */
> - M68K_FEATURE_BITFIELD, /* BFxxx Bit field insns. (680[2346]0) */
> - M68K_FEATURE_FPU, /* fpu insn. (680[46]0) */
> - M68K_FEATURE_CAS, /* CAS/CAS2[WL] insns. (680[2346]0) */
> - M68K_FEATURE_BKPT, /* BKPT insn. (680[12346]0, and CPU32) */
> - M68K_FEATURE_RTD, /* RTD insn. (680[12346]0, and CPU32) */
> - M68K_FEATURE_CHK2, /* CHK2 insn. (680[2346]0, and CPU32) */
> - M68K_FEATURE_MOVEP, /* MOVEP insn. (680[01234]0, and CPU32) */
> - M68K_FEATURE_MOVEC, /* MOVEC insn. (from 68010) */
> + /* Revision B EMAC (dual accumulate). */
> + M68K_FEATURE_CF_EMAC_B,
> + /* User Stack Pointer. (680[012346]0, ISA A+, B or C). */
> + M68K_FEATURE_USP,
> + /* Master Stack Pointer. (680[234]0) */
> + M68K_FEATURE_MSP,
> + /* 68020+ full extension word. */
> + M68K_FEATURE_EXT_FULL,
> + /* word sized address index registers. */
> + M68K_FEATURE_WORD_INDEX,
> + /* scaled address index registers. */
> + M68K_FEATURE_SCALED_INDEX,
> + /* 32 bit mul/div. (680[2346]0, and CPU32) */
> + M68K_FEATURE_LONG_MULDIV,
> + /* 64 bit mul/div. (680[2346]0, and CPU32) */
> + M68K_FEATURE_QUAD_MULDIV,
> + /* Bcc with Long branches. (680[2346]0, and CPU32) */
> + M68K_FEATURE_BCCL,
> + /* BFxxx Bit field insns. (680[2346]0) */
> + M68K_FEATURE_BITFIELD,
> + /* fpu insn. (680[46]0) */
> + M68K_FEATURE_FPU,
> + /* CAS/CAS2[WL] insns. (680[2346]0) */
> + M68K_FEATURE_CAS,
> + /* BKPT insn. (680[12346]0, and CPU32) */
> + M68K_FEATURE_BKPT,
> + /* RTD insn. (680[12346]0, and CPU32) */
> + M68K_FEATURE_RTD,
> + /* CHK2 insn. (680[2346]0, and CPU32) */
> + M68K_FEATURE_CHK2,
> + /* MOVEP insn. (680[01234]0, and CPU32) */
> + M68K_FEATURE_MOVEP,
> + /* MOVEC insn. (from 68010) */
> + M68K_FEATURE_MOVEC,
> };
>
> static inline int m68k_feature(CPUM68KState *env, int feature)
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
next prev parent reply other threads:[~2021-03-08 18:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 12:11 [PATCH v2 0/3] target/m68k: MacOS related fixes Mark Cave-Ayland
2021-03-08 12:11 ` [PATCH v2 1/3] target/m68k: don't set SSW ATC bit for physical bus errors Mark Cave-Ayland
2021-03-09 19:46 ` Laurent Vivier
2021-03-08 12:11 ` [PATCH v2 2/3] target/m68k: reformat m68k_features enum Mark Cave-Ayland
2021-03-08 17:33 ` Laurent Vivier [this message]
2021-03-09 14:21 ` Richard Henderson
2021-03-09 19:46 ` Laurent Vivier
2021-03-08 12:11 ` [PATCH v2 3/3] target/m68k: add M68K_FEATURE_UNALIGNED_DATA feature Mark Cave-Ayland
2021-03-09 14:21 ` Richard Henderson
2021-03-09 19:47 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=732e8cd1-60d3-915a-0c8c-dff5d9c20449@vivier.eu \
--to=laurent@vivier.eu \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).